Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global.env editor and usage in docker operations #387

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

syko9000
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Adds a Gobal .env section to the settings page and uses both global.env and .env during docker operations if they exist. Pulls port for display from the docker ps call so that if the container is running then the ports are correct even if local parsing of .env files isn't exactly correct.

Fixes #133

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@louislam louislam added this to the 1.5.0 milestone Jan 23, 2024
@RafaelSchridi
Copy link

RafaelSchridi commented May 4, 2024

Hope you don't mind me giving feedback here, But I've been running this for a couple weeks now and it's been pretty amazing.
But I do feel like there are some things missing here that would be useful (maybe for a later revision?)

  1. You can't see what ENVs are available to you, usually you would scroll down and copy them from there, but now you need to have another tab open.
  2. Can't edit/see the global.env of other agents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants