Update Tldraw regex to detect both x.com AND twitter.com urls to preserve embed capabilities #11321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y of test with x.com url
|
|
|
e2e tests fail. I'll check it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
After X.com changed their urls to default to x.com instead of twitter.com the code stopped detecting pasted urls
See issue #11319
Solution
Update
TWITTER_REGEXtoX_OR_TWITTER_REGEXto now recognize both urlsSee Regex debugger
All add new E2E test for x.com urls based on copy of existing twitter.com test
Other Notes
Given my inexperience with LogSeq PR's and some maintainer might want to take this over.
I thought it would be simple one to fix though and an opportunity to help 😅
Closes #1139