fix: GH-910 separate error handlers #1000
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a complete fix for #910 but it at least makes it so
I figured the ternary expression was only there because there was a single handler function.
Once I made this change, I could see that I was getting a transaction abort not an error. The distinction was hard to tell before just based on line numbers as they used the same function. The error for the aborted transaction is:
I don't know what's causing that, but that's not relevant to this PR. Although I'll happily accept any guesses on where to look for it.
CC @mimittqq who requested this in the linked issue too.
CC @tokmakoff