Prepare several Gradle 9.0 deprecations #5686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sh-cho Thanks! |
Oh I just replaced all 😅 |
`JavaExecSpec.main` property is deprecated. Use the `mainClass` property instead.
The `AbstractArchiveTask.archivePath` property has been deprecated. This is scheduled to be removed in Gradle 9.0. https://docs.gradle.org/8.7/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html
It will be handled in the `gradle-scripts` repository.
sh-cho
force-pushed
the
prepare-gradle-9.0
branch
from
6156faa
to
ae87f9b
Compare
subrepo: subdir: "gradle/scripts" merged: "f716cfe16" upstream: origin: "https://github.com/line/gradle-scripts" branch: "main" commit: "f716cfe16" git-subrepo: version: "0.4.5" origin: "https://github.com/ingydotnet/git-subrepo" commit: "aa416e4"
minwoox
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Thanks, @sh-cho!
I pushed a commit that fetches the upstream change.
line/gradle-scripts@f716cfe
trustin
reviewed
Jun 5, 2024
subrepo: subdir: "gradle/scripts" merged: "a3211a7ec" upstream: origin: "https://github.com/line/gradle-scripts" branch: "main" commit: "a3211a7ec" git-subrepo: version: "0.4.6" origin: "https://github.com/Homebrew/brew" commit: "e130e47f23"
trustin
approved these changes
Jun 7, 2024
|
Thanks a lot, @sh-cho! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Prepare deprecations which will be removed or fail in Gradle 9.0
Modifications:
JavaExecSpec.maintomainClass(https://docs.gradle.org/8.7/javadoc/org/gradle/process/JavaExecSpec.html#setMain-java.lang.String-)AbstractArchiveTask.archivePathwitharchiveFile(https://docs.gradle.org/8.7/javadoc/org/gradle/api/tasks/bundling/AbstractArchiveTask.html#getArchivePath--)Result: