-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SELF for Builder Self Type Parameter #5685
Conversation
Motivation: See line#5684 for the motivation. Modifications: - Refactored builder classes to use the SELF type parameter for the builder's self-referencing methods. - Didn't refactor builder classes if their parent classes are public due to breaking changes. Will revisit this later if making change is acceptable. Result: - Reduced the need for cumbersome and error-prone method overrides.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm all for making the implementation simpler 👍 If there are any issues (e.g. javadoc), I'd rather they be handled directly rather than us adding thousands of lines of code to avoid the issue.
Resolving the conflicts is done. Meanwhile, I found other classes that I can also fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍👍
Motivation: See line#5684 for the motivation. Modifications: - Refactored builder classes to use the SELF type parameter for the builder's self-referencing methods. - Didn't refactor builder classes if their parent classes are public due to breaking changes. Will revisit this later if making changes is acceptable. Result: - Reduced the need for cumbersome and error-prone method overrides.
Motivation:
See #5684 for the motivation.
Modifications:
Result: