Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update check-style setting for LY corp copyright #5678

Merged
merged 2 commits into from
May 23, 2024

Conversation

taisey
Copy link
Contributor

@taisey taisey commented May 14, 2024

Motivation:
In the latest developer guide, it is recommended to use Copyright $today.year LY Corporation, but the check-style settings have not been adapted accordingly. When this copyright notice is used, a check-style warning occurs.
Modifications:

  • Updated check-style setting for LY corp copyright

Result:

  • Using either LINE copyright or LY copyright will pass the check-style test.

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taisey taisey marked this pull request as ready for review May 17, 2024 06:56
Copy link
Contributor

@jrhee17 jrhee17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@minwoox minwoox merged commit 1fa5442 into line:main May 23, 2024
14 of 15 checks passed
@minwoox
Copy link
Member

minwoox commented May 23, 2024

👍 👍 👍

Dogacel pushed a commit to Dogacel/armeria that referenced this pull request Jun 8, 2024
Motivation:
In the latest developer guide, it is recommended to use `Copyright $today.year LY Corporation`, but the check-style settings have not been adapted accordingly. When this copyright notice is used, a check-style warning occurs.
Modifications:

- Updated check-style setting for LY corp copyright

Result:

- Using either LINE copyright or LY copyright will pass the check-style test.

<!--
Visit this URL to learn more about how to write a pull request description:
https://armeria.dev/community/developer-guide#how-to-write-pull-request-description
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants