[Issue-4917] Add blockingTaskExecutor in Thrift services #5619

ChangguHan · 2024-04-18T05:50:45Z

Motivation:

Add blockingTaskExecutor in Thrift services #4917

Modifications:

Add useBlockingTaskExecutor into THttpServiceBuilder.java
Apply useBlockingTaskExecutor into THttpService.java

Result:

Closes Allow useBlockingTaskExecutor in Thrift services #4917. (If this resolves the issue.)
User can use useBlockingTaskExecutor from THttpServiceBuilder.java

CLAassistant · 2024-04-18T05:50:51Z

All committers have signed the CLA.

github-actions · 2024-04-18T06:05:56Z

🔍 Build Scan® (commit: `bc11840`)

Job name	Status	Build Scan®

injae-kim · 2024-04-19T01:20:35Z

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/THttpService.java

+        if (useBlockingTaskExecutor) {
+            ctx.blockingTaskExecutor().execute(
+                    () -> invoke(ctx, serializationFormat, seqId, f, decodedReq, httpRes)
+            );


we think invoke() is only thing that we should wrap with ctx.blockingTaskExecutor().

If not, please share to us~! 🙇

ikhoon · 2024-04-22T10:52:58Z

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/THttpService.java

@@ -287,6 +287,7 @@ public static Function<? super RpcService, THttpService> newDecorator(

    private int maxRequestStringLength;
    private int maxRequestContainerLength;
+    private boolean useBlockingTaskExecutor;


Suggested change

private boolean useBlockingTaskExecutor;

private final boolean useBlockingTaskExecutor;

Fixed it. Thank you

ikhoon · 2024-04-22T11:10:47Z

...ft/thrift0.13/src/test/java/com/linecorp/armeria/server/thrift/THttpServiceBlockingTest.java

+        @Override
+        public void get(TestServiceRequest request,
+                        AsyncMethodCallback resultHandler) throws TException {
+            resultHandler.onComplete(new TestServiceResponse(request.getMessage()));


Could we check whether the current thread is the blocking task executor?

Should we also check TestService.Iface?

Could we check whether the current thread is the blocking task executor?

I checked it here

armeria/thrift/thrift0.13/src/test/java/com/linecorp/armeria/server/thrift/THttpServiceBlockingTest.java

Line 81 in 6649eee

assertThat(blocking).isFalse();

Should we also check TestService.Iface?

Fixed it. Because of Iface, only verified the current thread is blocking executor without adding useBlockingTaskExecutor

thrift/thrift0.13/src/test/thrift/Test.thrift

minwoox

Looks great to me. 👍
Left minor suggestions. 😉

...ft/thrift0.13/src/test/java/com/linecorp/armeria/server/thrift/THttpServiceBlockingTest.java

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/THttpService.java

minwoox

Looks great to me, @ChangguHan 👍 👍 👍
Thanks!

minwoox · 2024-04-23T11:55:48Z

Oops, I realized that we also need to fix ThriftCallService not to use blocking task executor twice:

armeria/thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

Line 186 in 10424c7

ctx.blockingTaskExecutor().execute(() -> {

private static void invoke(
        ServiceRequestContext ctx,
        Object impl, ThriftFunction func, List<Object> args, CompletableRpcResponse reply) {

    try {
        final TBase<?, ?> tArgs = func.newArgs(args);
        if (func.isAsync()) {
            invokeAsynchronously(impl, func, tArgs, reply);
        } else if (ctx.eventLoop().inEventLoop()) {
            invokeSynchronously(ctx, impl, func, tArgs, reply);
        } else {
            invokeSynchronously0(ctx, impl, func, tArgs, reply);
        }
    } catch (Throwable t) {
        reply.completeExceptionally(t);
    }
}

private static void invokeSynchronously(
        ServiceRequestContext ctx, Object impl,
        ThriftFunction func, TBase<?, ?> args, CompletableRpcResponse reply) {
    ctx.blockingTaskExecutor().execute(() -> invokeSynchronously0(ctx, impl, func, args, reply));
}

private static void invokeSynchronously0(
        ServiceRequestContext ctx, Object impl,
        ThriftFunction func, TBase<?, ?> args, CompletableRpcResponse reply) {
    ...
}

trustin

Whether to delegate the call to the blocking task executor should be decided by ThriftCallService, not THttpService.

...ft/thrift0.13/src/test/java/com/linecorp/armeria/server/thrift/THttpServiceBlockingTest.java

ChangguHan · 2024-04-24T12:57:51Z

@trustin
I fix to decide whether to check useBlockingTaskExecutor in ThriftCallService instead of THttpService.
Would you check this?

armeria/thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

Lines 125 to 139 in 0963905

    
           if (func.isAsync()) { 
        
               if (useBlockingTaskExecutor) { 
        
                   ctx.blockingTaskExecutor().execute(() -> { 
        
                       try { 
        
                           invokeAsynchronously(impl, func, tArgs, reply); 
        
                       } catch (Throwable t) { 
        
                           reply.completeExceptionally(t); 
        
                       } 
        
                   }); 
        
               } else { 
        
                   invokeAsynchronously(impl, func, tArgs, reply); 
        
               } 
        
           } else { 
        
               invokeSynchronously(ctx, impl, func, tArgs, reply); 
        
           }

ChangguHan · 2024-04-24T12:58:48Z

Oops, I realized that we also need to fix ThriftCallService not to use blocking task executor twice:

armeria/thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

Line 186 in 10424c7

ctx.blockingTaskExecutor().execute(() -> {

private static void invoke(
        ServiceRequestContext ctx,
        Object impl, ThriftFunction func, List<Object> args, CompletableRpcResponse reply) {

    try {
        final TBase<?, ?> tArgs = func.newArgs(args);
        if (func.isAsync()) {
            invokeAsynchronously(impl, func, tArgs, reply);
        } else if (ctx.eventLoop().inEventLoop()) {
            invokeSynchronously(ctx, impl, func, tArgs, reply);
        } else {
            invokeSynchronously0(ctx, impl, func, tArgs, reply);
        }
    } catch (Throwable t) {
        reply.completeExceptionally(t);
    }
}

private static void invokeSynchronously(
        ServiceRequestContext ctx, Object impl,
        ThriftFunction func, TBase<?, ?> args, CompletableRpcResponse reply) {
    ctx.blockingTaskExecutor().execute(() -> invokeSynchronously0(ctx, impl, func, args, reply));
}

private static void invokeSynchronously0(
        ServiceRequestContext ctx, Object impl,
        ThriftFunction func, TBase<?, ?> args, CompletableRpcResponse reply) {
    ...
}

@minwoox Thank you for your review.
I fix to check in ThriftCallService!

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

trustin · 2024-04-30T08:36:47Z

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

-        requireNonNull(implementations, "implementations");
-        return new ThriftCallService(implementations);
+    public static ThriftCallServiceBuilder builder() {
+        return new ThriftCallServiceBuilder();
    }


Ditto, we need this method so we don't break backward compatibility.

I added it. Thank you!

It looks like it's not added back? There's no public static ThriftCallService of(Map<String, ? extends Iterable<?>> implementations) in ThriftCallService anymore.

trustin · 2024-04-30T08:37:35Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+    /**
+     * Adds an implementation for {@link ThriftServiceEntry}.
+     */
+    public ThriftCallServiceBuilder implementation(Object implementation) {


Should we rename this to addService() so it is close to GrpcServiceBuilder?

I change the name of this method. Thank you!

trustin · 2024-04-30T08:40:39Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+ * @see ThriftCallService
+ */
+public final class ThriftCallServiceBuilder {
+    private Map<String, ? extends Iterable<?>> implementations;


What do you think about making this additive, like:

private final ImmutableMap.Builder<String, ...> implementations = ImmutableMap.builder(); ... public ThriftCallService build() { ... final Map<...> implementations = this.implementations.build(); ... } // User code: ThriftCallService .builder() .addService(defaultServceImpl) .addService("foo", fooServiceImpl) .addService("bar", barServiceImpl) .addService("foobar", fooServiceImpl, barServiceImpl) .addServices(ImmutableMap.of("qux", quxServiceImpl, "quz", quzServiceImpl)) .build(); // implementations will contain "", "foo", "bar", "foobar", "qux", "quz".

It looks good.
I applied it. Thank you for your comment.

ChangguHan · 2024-05-07T06:41:25Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+ * @see ThriftCallService
+ */
+public final class ThriftCallServiceBuilder {
+    private final ImmutableMap.Builder<String, Iterable<?>> implementations = ImmutableMap.builder();


Please note that I changed the type of value here.
? extends Iterable<?> -> Iterable<?>

trustin · 2024-05-07T13:28:38Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+    /**
+     * Adds multiple implementations for {@link ThriftServiceEntry}.
+     */
+    public ThriftCallServiceBuilder implementations(Map<String, ? extends Iterable<?>> implementations) {


Maybe we can rename this to addServices as well?

trustin · 2024-05-07T13:31:56Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+     */
+    public ThriftCallServiceBuilder addService(String key, Object implementation) {
+        requireNonNull(implementation, "implementation");
+        this.implementations.put(key, ImmutableList.of(implementation));


This will overwrite the existing map entry under the specified key, making the following code work incorrectly:

builder.addService("foobar", fooService); builder.addService("foobar", barService);

There are two options to fix this here:

Use ImmutableMultiMap.Builder from Guava

Check if there's already a mapping and then merge if so.

Also, it'd be nice if a user is allowed to specify multiple implementations in a single call:

builder.addService("foobar", fooService, barService); // and builder.addService("foobar", ImmutableList.of(fooService, barService));

We could replace addService() with this new method, then.

@trustin
Is it okay to use like this? I also added test here.

armeria/thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

Lines 34 to 48 in 649bf67

* * ThriftCallService service = ThriftCallService

* .builder()

* .addService(defaultServiceImpl) // Adds an service

* .addService("foo", fooServiceImpl) // Adds an service with a key

* .addService("foobar", fooServiceImpl) // Adds multiple services to the same key

* .addService("foobar", barServiceImpl)

* .addService("foobarOnce", fooServiceImpl, barServiceImpl) // Adds multiple services at once

* // Adds multiple services by list

* .addService("foobarList", ImmutableList.of(fooServiceImpl, barServiceImpl))

* // Adds multiple services by map

* .addServices(ImmutableMap.of("fooMap", fooServiceImpl, "barMap", barServiceImpl))

* // Adds multiple services by multimap

* .addServices(ImmutableMultimap.of("foobarMultiMap", fooServiceImpl,

* "foobarMultiMap", barServiceImpl))

* .build();

jrhee17

Looks almost done once @trustin 's comments are addressed 👍

jrhee17 · 2024-05-08T00:01:16Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+ * @see ThriftCallService
+ */
+public final class ThriftCallServiceBuilder {
+    private final ImmutableMap.Builder<String, Iterable<?>> implementations = ImmutableMap.builder();


What do you think of consistently naming implementations -> services? Ditto for the method parameters and validations.

Done, Thank you!

jrhee17 · 2024-05-08T00:02:52Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+     */
+    public ThriftCallServiceBuilder addService(String key, Object implementation) {
+        requireNonNull(implementation, "implementation");
+        this.implementations.put(key, ImmutableList.of(implementation));


Suggested change

this.implementations.put(key, ImmutableList.of(implementation));

implementations.put(key, ImmutableList.of(implementation));

jrhee17 · 2024-05-08T00:26:00Z

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

            ServiceRequestContext ctx,
            Object impl, ThriftFunction func, List<Object> args, CompletableRpcResponse reply) {

        try {
            final TBase<?, ?> tArgs = func.newArgs(args);
            if (func.isAsync()) {
-                invokeAsynchronously(impl, func, tArgs, reply);
+                if (useBlockingTaskExecutor) {
+                    ctx.blockingTaskExecutor().execute(() -> {


Note: I understood that unlike gRPC interceptors, thrift rpcDecorators won't be invoked from the blockingTaskExecutor.

That is correct.
I left this comment to call the Thrift RPC decorators from the blockingTaskExecutor but @trustin suggested using the event loop for executing RPC decorators.

jrhee17 · 2024-05-08T00:34:24Z

...ft/thrift0.13/src/test/java/com/linecorp/armeria/server/thrift/THttpServiceBlockingTest.java

+            new ScheduledThreadPoolExecutor(1, ThreadFactories.newThreadFactory("blocking-test", true)) {
+                @Override
+                protected void beforeExecute(Thread t, Runnable r) {
+                    blocking.set(true);


This will make blocking=true for any blocking task execution - even if there is a different call path which uses blocking task executors (of which there are many)

Is it possible to just check blocking.set(Thread.currentThread().getName().startsWith("blocking-test")); inside the service call methods instead and remove this logic?

I haven't thought about it.
I appreciate your idea. Thank you.

minwoox

Looks good! Left minor comments. 👍

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

minwoox · 2024-05-20T14:46:41Z

thrift/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallService.java

            ServiceRequestContext ctx,
            Object impl, ThriftFunction func, List<Object> args, CompletableRpcResponse reply) {

        try {
            final TBase<?, ?> tArgs = func.newArgs(args);
            if (func.isAsync()) {
-                invokeAsynchronously(impl, func, tArgs, reply);
+                if (useBlockingTaskExecutor) {
+                    ctx.blockingTaskExecutor().execute(() -> {


That is correct.
I left this comment to call the Thrift RPC decorators from the blockingTaskExecutor but @trustin suggested using the event loop for executing RPC decorators.

trustin · 2024-06-05T17:11:36Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+    public ThriftCallServiceBuilder addService(String key, Object... service) {
+        requireNonNull(key, "key");
+        requireNonNull(service, "service");
+        servicesBuilder.putAll(key, service);


Should we also throw an IllegalArgumentException if service.length == 0?

trustin · 2024-06-05T17:11:58Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+        requireNonNull(key, "key");
+        requireNonNull(service, "service");
+        if (!service.iterator().hasNext()) {
+            throw new IllegalArgumentException("service should not be empty");


Could use checkArgument(...)

trustin · 2024-06-05T17:12:37Z

...ft/thrift0.13/src/main/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilder.java

+    /**
+     * Adds a service for {@link ThriftServiceEntry}.
+     */
+    public ThriftCallServiceBuilder addService(Object... service) {


Could we rename all addService methods to addServices(), given they can add more than one service anyway?

trustin · 2024-06-05T17:14:36Z

thrift/thrift0.13/src/test/java/com/linecorp/armeria/it/thrift/ThriftDynamicTimeoutTest.java

@@ -67,11 +67,11 @@ class ThriftDynamicTimeoutTest {
        @Override
        protected void configure(ServerBuilder sb) throws Exception {
            // Used for testing if changing the timeout dynamically works.
-            sb.service("/sleep", ThriftCallService.of(sleepService)
+            sb.service("/sleep", ThriftCallService.builder().addService(sleepService).build()


trustin · 2024-06-05T17:14:43Z

thrift/thrift0.13/src/test/java/com/linecorp/armeria/it/thrift/ThriftDynamicTimeoutTest.java

                                                  .decorate(DynamicTimeoutService::new)
                                                  .decorate(THttpService.newDecorator()));
            // Used for testing if disabling the timeout dynamically works.
-            sb.service("/fakeSleep", ThriftCallService.of(fakeSleepService)
+            sb.service("/fakeSleep", ThriftCallService.builder().addService(fakeSleepService).build()


trustin · 2024-06-05T17:15:16Z

thrift/thrift0.13/src/test/java/com/linecorp/armeria/it/thrift/ThrottlingRpcServiceTest.java

@@ -48,11 +48,11 @@ public class ThrottlingRpcServiceTest {
    public final ServerRule server = new ServerRule(false) {
        @Override
        protected void configure(ServerBuilder sb) {
-            sb.service("/thrift-never", ThriftCallService.of(serviceHandler)
+            sb.service("/thrift-never", ThriftCallService.builder().addService(serviceHandler).build()


trustin · 2024-06-05T17:15:19Z

thrift/thrift0.13/src/test/java/com/linecorp/armeria/it/thrift/ThrottlingRpcServiceTest.java

                                                         .decorate(ThrottlingRpcService.newDecorator(never()))
                                                         .decorate(THttpService.newDecorator()));

-            sb.service("/thrift-always", ThriftCallService.of(serviceHandler)
+            sb.service("/thrift-always", ThriftCallService.builder().addService(serviceHandler).build()


trustin · 2024-06-05T17:16:06Z

thrift/thrift0.13/src/test/java/com/linecorp/armeria/server/thrift/THttpClientTest.java

-                                 }).decorate(THttpService.newDecorator());
+                ThriftCallService
+                        .builder()
+                        .addServices(ImmutableMap.of("", ImmutableList.of(


trustin · 2024-06-05T17:23:17Z

...hrift0.13/src/test/java/com/linecorp/armeria/server/thrift/ThriftCallServiceBuilderTest.java

+        assertTrue(service.entries().containsKey(""));
+        final Iterator<?> defaultIterator = service.entries().get("").implementations.iterator();
+        assertEquals(defaultServiceImpl, defaultIterator.next());
+        assertFalse(defaultIterator.hasNext());


I think the assertion logic of this test method is not easy to read. How about building a map that contains the expected keys and values and just compare it to the return value of service.entries()? e.g.

final Map<String, List<Object>> actualEntries = service.entries().entrySet().stream()....collect(...); final Map<String, List<Object>> expectedEntries = ImmutableMap.builder()...build(); assertThat(actualEntries).isEqualsTo(expectedEntries);

[Issue-4917] Add blockingTaskExecutor in Thrift services

02c82e0

github-actions bot requested review from ikhoon, jrhee17, minwoox and trustin April 18, 2024 05:50

[Issue-4917] Fix test

3dda165

injae-kim reviewed Apr 19, 2024

View reviewed changes

ikhoon added new feature sprint Issues for OSS Sprint participants labels Apr 22, 2024

ikhoon reviewed Apr 22, 2024

View reviewed changes

[Issue-4917] Add test for Iface

6649eee

minwoox reviewed Apr 23, 2024

View reviewed changes

ChangguHan added 2 commits April 23, 2024 12:00

[Issue-4917] Refactor THttpService.invoke

286f804

[Issue-4917] Fix style

16e9e59

minwoox approved these changes Apr 23, 2024

View reviewed changes

trustin requested changes Apr 23, 2024

View reviewed changes

...ft/thrift0.13/src/test/java/com/linecorp/armeria/server/thrift/THttpServiceBlockingTest.java Outdated Show resolved Hide resolved

ChangguHan added 2 commits April 24, 2024 14:34

[Issue-4917] Run blocking in ThriftCallService

d625b8f

[Issue-4917] add ThriftCallServiceBuilder

0963905

trustin reviewed Apr 30, 2024

View reviewed changes

[Issue-4917] fix to keep compatibility

aa97734

ChangguHan commented May 7, 2024

View reviewed changes

trustin reviewed May 7, 2024

View reviewed changes

jrhee17 reviewed May 8, 2024

View reviewed changes

[Issue-4917] fix to keep compatibility

649bf67

ChangguHan requested a review from trustin May 17, 2024 06:59

ChangguHan requested a review from jrhee17 May 17, 2024 06:59

ChangguHan added 3 commits May 17, 2024 19:06

[Issue-4917] fix to disallowed class(es) in the public API

b3dd89f

[Issue-4917] fix to checkstyle

78ff4d1

[Issue-4917] fix doc

abfc035

minwoox reviewed May 20, 2024

View reviewed changes

ChangguHan and others added 2 commits May 27, 2024 09:32

[Issue-4917] fix docs and add @UnstableApi

c072de7

Merge branch 'main' into feature/issue-4917

bc11840

trustin reviewed Jun 5, 2024

View reviewed changes

	private boolean useBlockingTaskExecutor;
	private final boolean useBlockingTaskExecutor;

	* * ThriftCallService service = ThriftCallService
	* .builder()
	* .addService(defaultServiceImpl) // Adds an service
	* .addService("foo", fooServiceImpl) // Adds an service with a key
	* .addService("foobar", fooServiceImpl) // Adds multiple services to the same key
	* .addService("foobar", barServiceImpl)
	* .addService("foobarOnce", fooServiceImpl, barServiceImpl) // Adds multiple services at once
	* // Adds multiple services by list
	* .addService("foobarList", ImmutableList.of(fooServiceImpl, barServiceImpl))
	* // Adds multiple services by map
	* .addServices(ImmutableMap.of("fooMap", fooServiceImpl, "barMap", barServiceImpl))
	* // Adds multiple services by multimap
	* .addServices(ImmutableMultimap.of("foobarMultiMap", fooServiceImpl,
	* "foobarMultiMap", barServiceImpl))
	* .build();

	this.implementations.put(key, ImmutableList.of(implementation));
	implementations.put(key, ImmutableList.of(implementation));

[Issue-4917] Add blockingTaskExecutor in Thrift services #5619

Are you sure you want to change the base?

[Issue-4917] Add blockingTaskExecutor in Thrift services #5619

Conversation

ChangguHan commented Apr 18, 2024

CLAassistant commented Apr 18, 2024 • edited

github-actions bot commented Apr 18, 2024 • edited

🔍 Build Scan® (commit: bc11840)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChangguHan Apr 23, 2024 • edited

Choose a reason for hiding this comment

minwoox left a comment

Choose a reason for hiding this comment

minwoox left a comment

Choose a reason for hiding this comment

minwoox commented Apr 23, 2024

trustin left a comment

Choose a reason for hiding this comment

ChangguHan commented Apr 24, 2024

ChangguHan commented Apr 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trustin Apr 30, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

trustin May 7, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jrhee17 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jrhee17 May 8, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

minwoox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLAassistant commented Apr 18, 2024 •

edited

github-actions bot commented Apr 18, 2024 •

edited

🔍 Build Scan® (commit: `bc11840`)

ChangguHan Apr 23, 2024 •

edited

trustin Apr 30, 2024 •

edited

trustin May 7, 2024 •

edited

jrhee17 May 8, 2024 •

edited