New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Resolves #10151: make editor always have dynamic size #10298
base: dev
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
Could you provide a video showing how it work please? Basically when the editor is not in the last column, and you resize the whole window, only the editor should be resized. All other columns should keep their own size. I'm not sure if that's what the code does, but maybe it is. Also we'll need some tests for it but first please provide a video. |
Hello Laurent, I've just made it so you're resizing the P.S. you can see at Video as requested: 2024-04-14.08-58-36.mp4 |
Thank you, that indeed looks good. Would you mind adding tests for it? Perhaps in
Is there any way to fix this? It seems it starts working once you resize one of the panel, so maybe it means the "width" property needs to be set right away? Or maybe some rule that auto-size panels when the width is undefined needs to be removed? |
Any update? |
Hello, Sorry for being late. I haven't started working on writing the tests yet. I'll do them in the weekend probably. |
I've added two simple tests, I'm unsure if they're enough or not. It's implied that if an element has neither
I can look into this, but I'm not sure if it's a good idea, as every new added element will have e.g. minimum width. |
I noticed other bugs... it's kind of amusing. This solution probably needs more work since the only way for it to work is if you pretty much resize all panes after resetting layout (not practical). Awaiting your tips. 2024-04-24.18-14-04.mp4Edit: this one was already existent before my change. |
Hello? |
Hi @G0maa, this last issue you found indeed would need to be fixed. Please let me know if you still want to work on this |
@laurent22 I'm still here. |
This resolves #10151.
By default all
layoutItem
s have aresizeableRight
set as true if not last child.This solution adds a
resizeableLeft
option inLayoutItem
type.And sets if as
true
if theeditor
is before that element.This change should be apparent only if there are elements after
editor
.