Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs / Added width and height attributes to visualizations #376

Closed
wants to merge 1 commit into from

Conversation

samulatitude
Copy link
Contributor

Describe your changes

Added width and height attributes to visualizations config in docs

Copy link

changeset-bot bot commented May 6, 2024

⚠️ No Changeset found

Latest commit: 862c630

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -62,6 +62,14 @@ To configure and customize the chart, you can add properties, some of which are
[See the section yFormat](#axis-x-and-y-options) to learn more about the options.
</ParamField>

<ParamField path="height" type="number">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put the attribute in code example to explain that it has to be like this height={200}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not in all visualizations at least in one https://github.com/latitude-dev/latitude/blob/862c630289310e193ad8e82ba1db71660229d983/docs/views/components/visualizations/area-chart.mdx#syntax

Another option is to put here an example. People not familiar with Svelte syntax can feel confused otherwise.

<AreaChart height={300} />

@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
@geclos geclos deleted the docs/added-measures-to-visualizations branch May 21, 2024 14:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants