Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #1108 #1109

Closed
wants to merge 2 commits into from
Closed

Fix for issue #1108 #1109

wants to merge 2 commits into from

Conversation

InAnYan
Copy link
Contributor

@InAnYan InAnYan commented May 14, 2024

Issue

Solves #1108.

Change

  • The default value of id in MessageWindowChatMemory.Builder is null.
  • The constructor of MessageWindowChatMemory checks for null id value. If it is null, then it will generate a random UUID.
  • Updated the documentation for MessageWindowChatMemory.Builder.id().

General checklist

  • There are no breaking changes
  • I have added unit and integration tests for my change
  • I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
  • I have manually run all the unit and integration tests in the core and main modules, and they are all green

@langchain4j
Copy link
Owner

Closing it as #1108 was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants