-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add new stop method WorkerJobLifecycle #3767
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is that if signalStop is not-blocking, then we will interrupt the thread leading to the task being not stopped gracefully.
I think we will need something more advanced like a way to wait "for a certain amount of time" for the thread to stop then killing it.
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@loicmathieu, Now, part of the worker shutdown process we await for the realtime triggers to complete stopping before interrupting them with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like where it goes ;)
I wonder if the other Thread may be refactor to do the same (or to provide the ability to do the same). Let's keep that in mind for later and merge this one asap.
part-of: #3734
part-of: kestra-io/plugin-kafka#75