Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump spegel version #10118

Merged
merged 1 commit into from
May 23, 2024
Merged

Bump spegel version #10118

merged 1 commit into from
May 23, 2024

Conversation

brandond
Copy link
Contributor

Proposed Changes

Bump Spegel version

Types of Changes

version bump

Verification

  • see linked issues
  • check version

Testing

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner May 17, 2024 00:24
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 41.77%. Comparing base (1d22b69) to head (1ac3cc5).

Files Patch % Lines
pkg/spegel/spegel.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10118      +/-   ##
==========================================
- Coverage   47.58%   41.77%   -5.82%     
==========================================
  Files         173      173              
  Lines       14651    14653       +2     
==========================================
- Hits         6972     6121     -851     
- Misses       6348     7367    +1019     
+ Partials     1331     1165     -166     
Flag Coverage Δ
e2etests 36.38% <0.00%> (-9.89%) ⬇️
inttests 37.00% <0.00%> (+17.21%) ⬆️
unittests 11.37% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@manuelbuil manuelbuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: Weren't we adding some extras to the spegel upstream code because there were some issues to complete the integration? IIRC the maintainer of Spegel upstream proactively was fixing some of those issues. Are we still carrying those extras?

@brandond
Copy link
Contributor Author

brandond commented May 23, 2024

We're currently carrying 1 revert and 2 changes. one of the revert/changes is related to error handling, the other is related to wildcard support where upstream has taken a different approach than we support in registries.yaml.

spegel-org/spegel@main...k3s-io:spegel:f3d2c40723149dcefc9b219dddc5bdd44cff0874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants