Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor positioning and unintentionally selected text. #167

Merged
merged 2 commits into from
May 26, 2024

Conversation

tools400
Copy link
Contributor

Bug fixes

  • Fixed unexpected text selection.
    Steps to reproduce the problem:
    • Select Send New Message... on a given queue.
    • Select the Payload tab.
    • Select type Bytes.
    • Click Import... to open the Select File dialog.
    • Ensure that the Select File dialog is placed over the hex editor area of the message editor.
      Actually the file that will be selected, must be over the hex editor area of the message editor.
    • Important: select the file with a mouse double-click.
    • The bytes displayed in the hex editor will be selected from the first byte to the last byte. The
      last byte is the byte where the double-click in the Select File dialog occurred.
  • Fixed problem, that the cursor was not correctly positioned in the "Bytes" message editor on a mouse click.
    Steps to reproduce the problem:
    • Select Send New Message... on a given queue.
    • Select the Payload tab.
    • Select type Bytes.
    • Import a message from the file system.
    • Click on the first byte of the message editor. Cursor is correctly positioned.
    • Click on the eight byte of the message editor. Cursor is positioned on the seventh byte.
    • Click on the sixteenth byte of the message editor. Cursor is positioned on the thirteenth byte.
    • Reason: CHAR_HEIGHT and CHAR_WIDTH are set to fix values instead of being calculated depending on the font.

@titou10titou10 titou10titou10 merged commit fd2840b into jmstoolbox:dev May 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants