-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add property outputTitle to CustomCommand #3579
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @stefanhaller. I've left a small suggestion comment, but the feature works as expected; nice work!
return err | ||
} | ||
} else { | ||
title = cmdStr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could avoid having the else
branch here by just assigning the cmdStr
value to title
as a default value and letting the conditional to override it if customCommand.OutputTitle != ""
. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, why not. Changed in ba35802.
It can optionally be used to set the title of the panel that shows the output of a command (when showOutput is true). If left unset, the command string is used as the title.
ba35802
to
22a38c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'll approve this to set my review as completed explicitly! 👍🏻
Add property
outputTitle
to CustomCommand. It can optionally be used to set the title of the panel that shows the output of a command (whenshowOutput
is true). If left unset, the command string is used as the title.Closes #3576.
go generate ./...
)docs/Config.md
) have been updated if necessary