Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hint about Config.md from PR template #3578

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

stefanhaller
Copy link
Collaborator

It used to be a common thing to have to update Config.md in a PR (and we often forgot despite the template). As of #3565 this is no longer necessary, so remove this from the template.

Updating docs in general is still a good thing to think about, so we leave this in.

@stefanhaller stefanhaller added the maintenance For refactorings, CI changes, tests, version bumping, etc label May 19, 2024
Copy link

codacy-production bot commented May 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for fc7b10f1
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fc7b10f) Report Missing Report Missing Report Missing
Head commit (f5d57f7) 51186 43107 84.22%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3578) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Feels great to not have to separately update Config.md anymore when you add a new keybinding or config option

It used to be a common thing to have to update Config.md in a PR (and we often
forgot despite the template). As of #3565 this is no longer necessary, so remove
this from the template.

Updating docs in general is still a good thing to think about, so we leave this
in.
@stefanhaller stefanhaller merged commit a4e9181 into master May 20, 2024
14 checks passed
@stefanhaller stefanhaller deleted the adapt-pr-template branch May 20, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance For refactorings, CI changes, tests, version bumping, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants