Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made CASC_SSM_PREFIX work properly with parameters stored in Secrets Manager #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

galargh
Copy link

@galargh galargh commented Nov 9, 2020

Description

According to this guide it is possible to reference Secrets Manager from Parameter Store. To do so parameter key must be prefixed with /aws/reference/secretsmanager/. This PR ensures that /aws/reference/secretsmanager/ prefixed is respected even if CASC_SSM_PREFIX variable is set.

Example

Given the following casc config entry

- credentials:
      - string:
        id: "cred-id"
        secret: /aws/reference/secretsmanager/my.parameter.name

and the following CASC_SSM_PREFIX value

export CASC_SSM_PREFIX='my.prefix'

the CASC SSM Plugin would try to retrieve a parameter with the following name

/aws/reference/secretsmanager/my.prefix.my.parameter.name
Testing
  • mvn test

@galargh
Copy link
Author

galargh commented Dec 18, 2020

@patbos Have you had a chance to have a look at this proposal?

@galargh
Copy link
Author

galargh commented Mar 2, 2021

@patbos I was wondering what your thoughts are on this one.

@mwos-sl
Copy link

mwos-sl commented Sep 7, 2021

Any chances to have this merged? We need to keep our own releases because of that :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants