New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports fullwidth characters #23

Open

hakoai wants to merge 2 commits into jbcarpanelli:master from hakoai:fullwidth-length

hakoai commented Mar 20, 2020

Thanks for making this library! I use it in my project.

If it is fullwidth characters , it will be missing.

spinnies.add("fullwidth characters", {text: "一二三四五六七八九十"});

I corresponded using "string-width".


          [fix]change method of counting character len

65bc530

hakoai force-pushed the fullwidth-length branch from 4684c67 to 681982e Compare

March 20, 2020 14:36


          [add]lock file

fe5c988

hakoai force-pushed the fullwidth-length branch from 681982e to fe5c988 Compare

March 20, 2020 14:36

Owner

jbcarpanelli commented Apr 8, 2020

Hey @hakoai! Sorry for the late response, and thank you for contributing 😄. I'm gonna make some room on the weekend to review this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment