Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/migration cyberduck release windows chocolatey #15479

Draft
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

RaveenaRamany
Copy link

Migration Jenkins-Pipeline Cyberduck-Realese-Windows-Chocolatey

RaveenaRamany and others added 30 commits December 10, 2023 17:27
…-release-windows

set distributionManagement repos to local
…ndows-to-actions-20231210-172433

Convert cyberduck-release-windows to GitHub Actions
…ndows-chocolatey-to-actions-20231211-122942

Convert cyberduck-release-windows-chocolatey to GitHub Actions
@RaveenaRamany RaveenaRamany requested a review from a team as a code owner December 18, 2023 15:42
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

windows\target\release\*.exe
windows\target\release\*.msi
windows\target\release\*.appx
!**/*~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all these exclusions? Are the 3 includes above not sufficient?

script: |-
const fs = require('fs').promises
const path = require('path')
const patterns = "windows/target/update/changelog.*,!**/*~,!**/#*#,!**/.#*,!**/%*%,!**/._*,!**/CVS,!**/CVS/**,!**/.cvsignore,!**/SCCS,!**/SCCS/**,!**/vssver.scc,!**/.svn,!**/.svn/**,!**/.DS_Store,!**/.git,!**/.git/**,!**/.gitattributes,!**/.gitignore,!**/.gitmodules,!**/.hg,!**/.hg/**,!**/.hgignore,!**/.hgsub,!**/.hgsubstate,!**/.hgtags,!**/.bzr,!**/.bzr/**,!**/.bzrignore"
Copy link
Contributor

@ylangisc ylangisc Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here with all the excludes. If not necessary the entire transfer task and ssh setup could be simplified using https://github.com/appleboy/scp-action.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we can dogfood Cyberduck CLI here. We have a Cyberduck CLI Github Action 1 to transfer artifacts. Documentation can be found in the README 2 and sample usage in our connection profiles synchronization with S3 3.

@AliveDevil May assist here when in doubt.

Footnotes

  1. https://github.com/iterate-ch/cyberduck-cli-action

  2. https://github.com/iterate-ch/cyberduck-cli-action/blob/main/README.md

  3. https://github.com/iterate-ch/profiles/blob/main/.github/workflows/profiles-sync.yml

with:
servers: |
[{
"id": "maven.iterate.ch-release",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maven.iterate repositories not necessary for Cyberduck builds.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be reverted before merge.

@dkocher dkocher marked this pull request as draft December 20, 2023 20:03
@dkocher dkocher added the github_actions Pull requests that update GitHub Actions code label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants