-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy stable validation policy to istiod-remote #50923
Copy stable validation policy to istiod-remote #50923
Conversation
86546ac
to
50b327e
Compare
Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
50b327e
to
20b2670
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there stable configuration tests for each chart type? Do we verify no non-stable resources are present for each applied chart type?
I can't easily think of a way to automatically test that the expected manifests are in each chart type. I am open to suggestions and we can create an issue to track it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PTAL @ericvn @zirain @stevenctl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For cherry-pick, please add release-notes.
This is a bug fix that relates to release channels. There is already a release notes for release channels. Do I still need to add another? |
Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
In response to a cherrypick label: new pull request created: #51268 |
Please provide a description of this PR:
Part of Release Channels: 173