-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for XInvoice #9523
Fixes for XInvoice #9523
Conversation
Currently waiting on horstoeko/zugferd#49 |
Ready for rewiev. See the questions above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 x small changes please.
@turbo124 done the requested changes. Could you please review my questions above? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of last minute items, also in reference to questions, i cannot see any additional questions?
@turbo124 , just mentioned you again in the open questions. Will fix the rest later |
@LarsK1 I think the questions are not in this repo's contexts, but your own? I'm not receiving notifications on these unfortunately so I am unable to track. Can you ping me on Slack to discuss? |
@turbo124 ready for final review |
Thanks! |
No description provided.