Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISPN-16075 Allow to use remote query API from the server task #12402

Merged
merged 4 commits into from
May 22, 2024
Merged

ISPN-16075 Allow to use remote query API from the server task #12402

merged 4 commits into from
May 22, 2024

Conversation

fax4ever
Copy link
Contributor

@fax4ever fax4ever commented May 20, 2024 •
edited

@github-actions github-actions bot added this to the 15.0.4.Final milestone May 20, 2024
@fax4ever fax4ever marked this pull request as ready for review May 21, 2024 14:01
@fax4ever fax4ever added the 15.0.x Annotate a PR with this label if you want it to be backported to the 15.0.x branch label May 21, 2024
pruivo
pruivo requested changes May 22, 2024
View reviewed changes
Copy link
Member

@pruivo pruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, the API should be similar to the one used by embedded and remote queries.
The remaining comments are mainly performance suggestions or nitpicks.

tasks/api/src/main/java/org/infinispan/tasks/query/RemoteQueryAccess.java Outdated Show resolved Hide resolved
tasks/api/src/main/java/org/infinispan/tasks/TaskContext.java Outdated Show resolved Hide resolved
...emote-query-server/src/main/java/org/infinispan/query/remote/impl/RemoteQueryAccessImpl.java Outdated Show resolved Hide resolved
...emote-query-server/src/main/java/org/infinispan/query/remote/impl/RemoteQueryAccessImpl.java Outdated Show resolved Hide resolved
...emote-query-server/src/main/java/org/infinispan/query/remote/impl/RemoteQueryAccessImpl.java Outdated Show resolved Hide resolved
@fax4ever
Copy link
Contributor Author

In my opinion, the API should be similar to the one used by embedded and remote queries. The remaining comments are mainly performance suggestions or nitpicks.

Thank you @pruivo. Great review!
I agreed on all the points here and applied all the ideas you provided.
Let me know if we can add other changes.

@pruivo pruivo merged commit 6d62873 into infinispan:main May 22, 2024
8 of 9 checks passed
@pruivo
Copy link
Member

pruivo commented May 22, 2024

merged! thanks @fax4ever !

@pruivo
Copy link
Member

pruivo commented May 22, 2024

@fax4ever the automatic backport job failed. Can you create the backport manually?

@fax4ever fax4ever deleted the ISPN-16075 branch May 23, 2024 06:33
@fax4ever
Copy link
Contributor Author

merged! thanks @fax4ever !

thanks!

@fax4ever
Copy link
Contributor Author

@fax4ever the automatic backport job failed. Can you create the backport manually?

sure!

@fax4ever fax4ever mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pruivo pruivo pruivo approved these changes

Assignees
No one assigned
Labels
15.0.x Annotate a PR with this label if you want it to be backported to the 15.0.x branch
Projects
None yet
Milestone
15.1.0.Dev01
3 participants
@fax4ever @pruivo @tristantarrant