-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISPN-16069 Allow the indexes to start with embedded setup #12377
Conversation
Rebased! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some suggestions 👍
...d-client/src/test/java/org/infinispan/client/hotrod/query/mode/EmbeddedIndexingModeTest.java
Show resolved
Hide resolved
.../main/java/org/infinispan/configuration/cache/AbstractIndexingConfigurationChildBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/infinispan/configuration/cache/IndexingConfigurationChildBuilder.java
Outdated
Show resolved
Hide resolved
@@ -81,6 +81,20 @@ Set the `indexing-mode` to `manual`: | |||
include::xml/indexing_manual.xml[] | |||
---- | |||
|
|||
[discrete] | |||
== Use (force) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use force?
[discrete] | ||
== Use (force) | ||
|
||
If the cache is Protobuf-encoded and the indexes initialized from a {brandname} server instance, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicking, I would use protostream
instead of protobuf
just to match the media type name.
Thank you Pedro for the review. |
documentation/src/main/asciidoc/topics/ref_indexing_configuration.adoc
Outdated
Show resolved
Hide resolved
2441b9e
to
7f98802
Compare
Please do not squash this commit, to make the backport to 15.0 easy
merged! thanks @fax4ever ! |
Thanks Pedro! |
https://issues.redhat.com/browse/ISPN-16069