ISPN-15916 Certificate reloading #12359
Conversation
| private static FileWatcher INSTANCE; | ||
|
|
||
| private final Thread thread; | ||
| private final WatchService watchService; |
There was a problem hiding this comment.
This won't work as expected in K8s:
https://blog.arkey.fr/2019/09/13/watchservice-and-bind-mount/
There was a problem hiding this comment.
I've modified it to use plain last modified time
tristantarrant
force-pushed
the
ISPN-15916/ssl_reload
branch
from
e711b60
to
97b66e5
Compare
| public void run() { | ||
| while (running) { | ||
| try { | ||
| Thread.sleep(SLEEP); |
There was a problem hiding this comment.
Shouldn't we be making use of a ScheduledExecutorService and in the case of the server should we be creating this via NamedExecutorsFactory?
There was a problem hiding this comment.
This is also used by the client.
| /** | ||
| * @since 15.0 | ||
| */ | ||
| public class FileWatcher implements Runnable { |
There was a problem hiding this comment.
Do we want to use a WatchService instead? https://docs.oracle.com/javase/tutorial/essential/io/notification.html It should theoretically be more lightweight (don't have to check all registered files) and more responsive when file system supports (no sleeps required).
There was a problem hiding this comment.
The initial implementation did use that, but read #12359 (comment)
There was a problem hiding this comment.
Ah, yes. Sorry, I only looked at the code not the prior comments :D
commons/all/src/main/java/org/infinispan/commons/io/FileWatcher.java
Outdated
Show resolved
Hide resolved
wburns
changed the title
tristantarrant
force-pushed
the
ISPN-15916/ssl_reload
branch
from
97b66e5
to
9bbe0db
Compare
|
@tristantarrant This is breaking CI, there's also @wburns comment that needs addressing. |
The first few runs of this PR in CI were broken because the |
tristantarrant
force-pushed
the
ISPN-15916/ssl_reload
branch
3 times, most recently
from
d490790
to
a4fdc4b
Compare
tristantarrant
force-pushed
the
ISPN-15916/ssl_reload
branch
2 times, most recently
from
a3b168a
to
6670ed2
Compare
tristantarrant
force-pushed
the
ISPN-15916/ssl_reload
branch
from
6670ed2
to
b61c0d3
Compare
tristantarrant
force-pushed
the
ISPN-15916/ssl_reload
branch
from
b61c0d3
to
ee6c3d4
Compare
|
Test failures are unrelated. |
|
Thanks @tristantarrant |
https://issues.redhat.com/browse/ISPN-15916