Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker compose pull rate limit #9600

Merged
merged 2 commits into from
May 20, 2024

Conversation

parsapoorsh
Copy link
Contributor

with registry.hub.docker.com/ behind the image reference, there was an issue where docker compose up -d would throw a rate-limiting error, even when logged in using a docker account.

before

poweruser@debian:~/immich-app$ docker pull registry.hub.docker.com/library/redis:6.2-alpine@sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672
Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

after changing image reference

poweruser@debian:~/immich-app$ docker pull redis:6.2-alpine@sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672
docker.io/library/redis@sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672: Pulling from library/redis
4abcf2066143: Pull complete 
2c3a1d240687: Pull complete 
643f361aa308: Pull complete 
a693cf0e318c: Pull complete 
ade57efb0b22: Pull complete 
2fa2e1566407: Pull complete 
4f4fb700ef54: Pull complete 
4464e0709769: Pull complete 
Digest: sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672
Status: Downloaded newer image for redis@sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672
docker.io/library/redis:6.2-alpine@sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672

What's Next?
  View a summary of image vulnerabilities and recommendations → docker scout quickview redis:6.2-alpine@sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672

it doesn't really matter where the image is downloaded from as long as it has the same sha256 hash in docker-compose.yml

with "registry.hub.docker.com/" behind the image name, there was an issue where "docker compose up -d" would throw a rate-limiting error, even when logged in using a docker account.

it doesn't really matter where the image is downloaded from as long as it has the same sha256 hash in docker-compose.yml
@parsapoorsh parsapoorsh requested a review from bo0tzz as a code owner May 19, 2024 11:37
@bo0tzz
Copy link
Member

bo0tzz commented May 19, 2024

This was explicitly added in #7496 for better compatibility with podman.

Some comments there suggest using docker.io/ instead. If you use that, does it resolve your ratelimiting issue? If so I think it's probably fine to change to that.

@parsapoorsh
Copy link
Contributor Author

it got fixed, i committed a new one with docker.io/ for image reference

test result:

poweruser@debian:/media/poweruser/data/immich-app$ docker pull docker.io/redis:6.2-alpine@sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672
docker.io/library/redis@sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672: Pulling from library/redis
4abcf2066143: Pull complete 
2c3a1d240687: Pull complete 
643f361aa308: Pull complete 
a693cf0e318c: Pull complete 
ade57efb0b22: Pull complete 
2fa2e1566407: Pull complete 
4f4fb700ef54: Pull complete 
4464e0709769: Pull complete 
Digest: sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672
Status: Downloaded newer image for redis@sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672
docker.io/library/redis:6.2-alpine@sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672

What's Next?
  View a summary of image vulnerabilities and recommendations → docker scout quickview docker.io/redis:6.2-alpine@sha256:84882e87b54734154586e5f8abd4dce69fe7311315e2fc6d67c29614c8de2672

@danieldietzler danieldietzler added the deployment Deployment related tasks label May 19, 2024
@alextran1502 alextran1502 merged commit c37bf9d into immich-app:main May 20, 2024
22 of 23 checks passed
@parsapoorsh parsapoorsh deleted the pull-docker-compose-fix branch May 27, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Deployment related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants