Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: library type #9525

Merged
merged 1 commit into from
May 20, 2024
Merged

refactor: library type #9525

merged 1 commit into from
May 20, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented May 15, 2024

  • Remove option to create upload libraries from the api
  • Convert upload libraries into libraryId: null
  • No longer create an upload library when a new user is created
  • Drop library.type column

Tested by adding a second user and creating an external library for each.

Before:
image

After:
image

@jrasm91 jrasm91 added 🗄️server external-library Issues related to external libraries labels May 15, 2024
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented May 15, 2024 •
edited

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: 46399b0
Status: ✅  Deploy successful!
Preview URL: https://4320c83d.immich.pages.dev
Branch Preview URL: https://refactor-library-type.immich.pages.dev

View logs

@jrasm91 jrasm91 force-pushed the refactor/library-type branch 3 times, most recently from d43f1c9 to 334ca56 Compare May 15, 2024 22:11
zackpollard
zackpollard approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@zackpollard zackpollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, couple of minor comments

server/src/dtos/asset-response.dto.ts Show resolved Hide resolved
server/src/entities/asset.entity.ts Outdated Show resolved Hide resolved
server/src/migrations/1715804005643-RemoveLibraryType.ts Show resolved Hide resolved
server/src/services/asset-v1.service.ts Show resolved Hide resolved
open-api/typescript-sdk/src/fetch-client.ts Show resolved Hide resolved
@jrasm91 jrasm91 merged commit 84d824d into main May 20, 2024
23 checks passed
@jrasm91 jrasm91 deleted the refactor/library-type branch May 20, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackpollard zackpollard zackpollard approved these changes

@danieldietzler danieldietzler danieldietzler approved these changes

@alextran1502 alextran1502 Awaiting requested review from alextran1502

Assignees
No one assigned
Labels
external-library Issues related to external libraries 🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrasm91 @zackpollard @danieldietzler