-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Dynamic task grouping #2639
base: master
Are you sure you want to change the base?
Conversation
src/lib/operators/aggregate_hash.cpp
Outdated
@@ -45,7 +45,7 @@ using namespace hyrise; // NOLINT | |||
// `get_or_add_result` is called once per row when iterating over a column that is to be aggregated. The row's `key` has | |||
// been calculated as part of `_partition_by_groupby_keys`. We also pass in the `row_id` of that row. This row id is | |||
// stored in `Results` so that we can later use it to reconstruct the values in the group-by columns. If the operator | |||
// calculates multiple aggregate functions, we only need to perform this lookup as part of the first aggregate function. | |||
// calculates multiple aggregate functions, we only need to perform this lookup as part of the first aggrete function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saved two bytes!
@@ -37,7 +37,7 @@ def is_setup(): | |||
|
|||
# This file contains the IMDB dataset and is based on the specifications of the | |||
# original JOB repository: https://github.com/gregrahn/join-order-benchmark | |||
LOCATION = "https://bit.ly/hyriseimdbdataset" | |||
LOCATION = "https://github.com/hyrise/hyrise/releases/download/imdb_data_set_v1.01/imdb_data.zip" | |||
FILE_NAME = "imdb_data.zip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am currently in contact with Matthias to find an HPI-internal solution. But it probably won't make it into this PR.
This is a draft PR for now. The main change is to change the fixed number of groups to use and make it dynamic, depending on the current workload.