-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Context.getShortcuts type #10910
Conversation
Hi @fanshi1028 Thank you for your contribution! We will review your PR and update you when we check if we can merge it. Before that, please add a changelog entry and tests for the new type. Thank you. |
Added a changelog but I don't know where/what to add tests for this fix. |
Hi @fanshi1028 It seems that you can add it here https://github.com/handsontable/handsontable/blob/develop/handsontable/src/shortcuts/__tests__/shortcutManager.types.ts |
* fix Context.getShortcuts type * add changelog * add a test for getShortcuts type fix --------- Co-authored-by: Aleksandra Budnik <AMBudnik@users.noreply.github.com> Co-authored-by: Jan Siegel <jansiegel@users.noreply.github.com>
- Change the release date to 11/06/24
Context
fix outdated type
How has this been tested?
Nope
Types of changes
Affected project(s):
handsontable
@handsontable/angular
@handsontable/react
@handsontable/vue
@handsontable/vue3
Checklist: