Bump minimum HA version to 2024.4.1 #3672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emontnemery
force-pushed
the
bump_min_ha_version_2024.4.0
branch
from
094c3a3
to
ea8df14
Compare
emontnemery
force-pushed
the
bump_min_ha_version_2024.4.0
branch
from
ea8df14
to
7fb8de8
Compare
emontnemery
force-pushed
the
bump_min_ha_version_2024.4.0
branch
from
11e088b
to
6fb0b21
Compare
ludeeus
reviewed
May 8, 2024
requirements_core_min.txt
Outdated
| homeassistant==2023.6.0 | ||
| # https://github.com/home-assistant/core/blob/2024.4.0/homeassistant/components/frontend/manifest.json | ||
| home-assistant-frontend==20240403.1 | ||
| homeassistant==2024.4.0 |
There was a problem hiding this comment.
Suggested change
| homeassistant==2024.4.0 | |
| homeassistant==2024.4.1 |
This also needs to be adjusted in hacs.json
There was a problem hiding this comment.
Fixed in 92d117a
ludeeus
reviewed
May 8, 2024
| @@ -299,14 +307,14 @@ def async_add_executor_job(target, *args): | |||
|
|
|||
| return orig_async_add_executor_job(target, *args) | |||
|
|
|||
| def async_create_task(coroutine, name=None): | |||
| def async_create_task(coroutine, name=None, eager_start=False): | |||
There was a problem hiding this comment.
This should be true if the core is > 2024.5.0, right?
There was a problem hiding this comment.
Yeah, updated here: #3673
ludeeus
reviewed
May 8, 2024
This reverts commit 6fb0b21.
emontnemery
changed the title
emontnemery
force-pushed
the
bump_min_ha_version_2024.4.0
branch
from
321183e
to
92d117a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
async_test_home_assistant_min_versiontest helper with changes in HA Core 2024.4.1These adjustments are kept for separate PRs: