Add async wrapper for commonly used filesystem functions #3584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
suggested changes
Apr 8, 2024
MartinHjelmare
approved these changes
Apr 8, 2024
balloob
reviewed
Apr 12, 2024
Comment on lines
800
to
801
| if await async_exists(self.hacs.hass, path): | ||
| await async_remove(self.hacs.hass, path) |
There was a problem hiding this comment.
It's bad to go into the executor twice. Can we add a feature to async_remove to not fail if a file doesn't exist ?
There was a problem hiding this comment.
If it's changed to use Path(filepath).unlink(missing_ok=True) it would be a single one.
There was a problem hiding this comment.
We could give async_remove a missing_ok flag
balloob
reviewed
Apr 12, 2024
emontnemery
commented
Apr 12, 2024
| @@ -467,7 +468,7 @@ def _write_file(): | |||
| self.log.error("Could not write data to %s - %s", file_path, error) | |||
| return False | |||
|
|
|||
| return os.path.exists(file_path) | |||
| return await async_exists(self.hass, file_path) | |||
There was a problem hiding this comment.
This check should be part of the _write_file function, that should be fixed in a separate PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add async wrapper for commonly used filesystem functions
os.path.existsandos.removeThis PR simply wraps file system accesses which currently happen from the event loop, separate follow-up PRs will handle optimizing the number of file system calls as needed.