[Feature] Add graphman unlink #5115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need testing and few todos
|
Hey @SozinM thanks so much for picking this up! Are you still working on this PR? |
|
Hi @azf20 |
Used existing query to get all subgraphs for unlinking
… into the private function and providing detailed interface for this function. This was done to introduce another function subgraph_ids_by_deployment_hash and avoid complex query duplication.
|
@lutter Could you provide concrete fields for the auditing table? I cannot find any mention of it anywhere. |
|
This pull request hasn't had any activity for the last 90 days. If there's no more activity over the course of the next 14 days, it will automatically be closed. |
|
@SozinM I will close this PR for the moment as it seems to be stale, feel free to re-open it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete part of #4947
Introducing the private function subgraphs_info_by_deployment_hash is done to keep the complex query in a single place and add another function (subgraph_ids_by_deployment_hash) to get different fields.
I didn't want to change the interface and logic of subgraphs_by_deployment_hash because it is used in other places and will cause cascade refactoring.