Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [release-3.0.x] docs(install-monolithic): add quotation marks #12993

Merged
merged 1 commit into from
May 20, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport 31a1314 from #12982


What this PR does / why we need it:

Example is broken.

Special notes for your reviewer:

Without the added quotation marks, the following error is thrown:

"failed parsing config: /etc/loki/config/config.yaml: Use -config.expand-env=true flag if you want to expand environment variables in your config file"

So without this change, the examples are not working properly.

In https://grafana.com/docs/loki/latest/operations/storage/tsdb/ the quotation marks are also used.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.

Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
(cherry picked from commit 31a1314)
@grafanabot grafanabot requested a review from a team as a code owner May 20, 2024 14:40
@grafanabot grafanabot added backport size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels May 20, 2024
@grafanabot grafanabot requested a review from JStickler May 20, 2024 14:40
@JStickler JStickler merged commit 8e54a3e into release-3.0.x May 20, 2024
54 of 55 checks passed
@JStickler JStickler deleted the backport-12982-to-release-3.0.x branch May 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/XS type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants