-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GOps: Add Grafana SLO steps to IRM configuration tracker #88098
Open
obetomuniz
wants to merge
2
commits into
main
Choose a base branch
from
betomuniz/slo/gops-configuration-tracker
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+103
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obetomuniz
requested review from
jtheory,
gillesdemey,
tomratcliffe,
konrad147 and
soniaAguilarPeiron
and removed request for
a team
May 20, 2024 14:50
obetomuniz
changed the title
GOps: add Grafana SLO steps to IRM configuration tracker
GOps: Add Grafana SLO steps to IRM configuration tracker
May 20, 2024
/deploy-to-hg |
|
|
obetomuniz
added
the
good cross gops-fe
Share with a GOps Frontend dev on another focus
label
May 20, 2024
gillesdemey
reviewed
May 30, 2024
const { data, isLoading } = sloApi.endpoints.getSlos.useQuery(undefined, { | ||
skip: !sloPluginInstalled, | ||
refetchOnFocus: true, | ||
refetchOnReconnect: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
gillesdemey
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM!
* main: (518 commits) FeatureFlags: Update creation timestamps (#88966) Alerting: Add ha_reconnect_timeout configuration option (#88823) Explore: Logs pinning in content outline (#88316) Alerting: use hash of labels instead of labels string as the alert state cache key (#88956) Alerting: Recording rules understands errors embedded in dataframes (#88946) Grafana live: Add tests and missing code to amendTable (#89031) Chore: Add extra check in keybinds e2e test to prevent flake (#89034) Docs: fixes overview text height (#89044) RecentlyDeleted: Remove search box (#89043) Keybinds: Allow move time range shortcuts (t left / t right) to be chained (#88904) Log: Added panel support for filtering callbacks (#88980) BarChart: Fix bar widths changing when toggling series (#89010) Chore: Use OrgRoleMapper in Grafana.com client (#89013) CI: Add release-pr workflow (#89005) Docs: landing page for OSS/Enterprise (#89030) Alerting: Fix erroneous use of grafana-cli/logger. (#89037) Chore: replace `General` with `Dashboards` (#89017) Frontend: InteractiveTable fix - prevent styles from leaking into tables added in expanded rows (#88948) I18n: Download translations from Crowdin (#89035) Calendar: Add labels for next/previous month (#89019) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
add to changelog
area/frontend
good cross gops-fe
Share with a GOps Frontend dev on another focus
no-backport
Skip backport of PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds Grafana SLO to the configuration tracker for Admins.
Who is this feature for?
For now, will be only for Admin users.
Which issue(s) does this PR fix?:
Fixes https://github.com/grafana/irm-timetovalue/issues/7
Special notes for your reviewer:
Please check that: