Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOps: Add Grafana SLO steps to IRM configuration tracker #88098

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

obetomuniz
Copy link
Member

@obetomuniz obetomuniz commented May 20, 2024

What is this feature?

This PR adds Grafana SLO to the configuration tracker for Admins.

Who is this feature for?

For now, will be only for Admin users.

Which issue(s) does this PR fix?:

Fixes https://github.com/grafana/irm-timetovalue/issues/7

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@obetomuniz obetomuniz requested a review from a team as a code owner May 20, 2024 14:50
@obetomuniz obetomuniz requested review from jtheory, gillesdemey, tomratcliffe, konrad147 and soniaAguilarPeiron and removed request for a team May 20, 2024 14:50
@obetomuniz obetomuniz self-assigned this May 20, 2024
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 20, 2024
@obetomuniz obetomuniz changed the title GOps: add Grafana SLO steps to IRM configuration tracker GOps: Add Grafana SLO steps to IRM configuration tracker May 20, 2024
@obetomuniz
Copy link
Member Author

/deploy-to-hg

@ephemeral-instances-bot
Copy link

  • Preparing your instance. A comment containing your instance's url will be added to this PR when the instance is ready.
  • Your instance will be ready in ~10 minutes. Follow the workflow progress
  • Slack channel: #proj-ephemeral-hg-instances
  • Building instance with betomuniz/slo/gops-configuration-tracker oss branch and main enterprise branch. How to choose a branch

@ephemeral-instances-bot
Copy link

@obetomuniz obetomuniz added the good cross gops-fe Share with a GOps Frontend dev on another focus label May 20, 2024
@obetomuniz obetomuniz modified the milestones: 11.1.x, 11.0.x May 21, 2024
const { data, isLoading } = sloApi.endpoints.getSlos.useQuery(undefined, {
skip: !sloPluginInstalled,
refetchOnFocus: true,
refetchOnReconnect: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Member

@gillesdemey gillesdemey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! :shipit:

* main: (518 commits)
  FeatureFlags: Update creation timestamps (#88966)
  Alerting: Add ha_reconnect_timeout configuration option (#88823)
  Explore: Logs pinning in content outline (#88316)
  Alerting: use hash of labels instead of labels string as the alert state cache key (#88956)
  Alerting: Recording rules understands errors embedded in dataframes (#88946)
  Grafana live: Add tests and missing code to amendTable (#89031)
  Chore: Add extra check in keybinds e2e test to prevent flake (#89034)
  Docs: fixes overview text height (#89044)
  RecentlyDeleted: Remove search box (#89043)
  Keybinds: Allow move time range shortcuts  (t left / t right) to be chained (#88904)
  Log: Added panel support for filtering callbacks (#88980)
  BarChart: Fix bar widths changing when toggling series (#89010)
  Chore: Use OrgRoleMapper in Grafana.com client (#89013)
  CI: Add release-pr workflow (#89005)
  Docs: landing page for OSS/Enterprise (#89030)
  Alerting: Fix erroneous use of grafana-cli/logger. (#89037)
  Chore: replace `General` with `Dashboards` (#89017)
  Frontend: InteractiveTable fix - prevent styles from leaking into tables added in expanded rows (#88948)
  I18n: Download translations from Crowdin (#89035)
  Calendar: Add labels for next/previous month (#89019)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend good cross gops-fe Share with a GOps Frontend dev on another focus no-backport Skip backport of PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants