Plugins: Hide version information when plugin is managed #88065
Conversation
wbrowne
added
area/plugins
no-backport
wbrowne
requested review from
Ukochka,
marefr,
andresmgot and
xnyo
and removed request for
a team
There was a problem hiding this comment.
I'd assume we need to add something in the UI to indicate that the plugin is running in "managed" mode. @sympatheticmoose can confirm
public/app/features/plugins/admin/components/InstallControls/InstallControlsButton.tsx
Outdated
Show resolved
Hide resolved
| if (plugin.isManaged) { | ||
| info.push({ | ||
| label: 'Version', | ||
| value: 'Managed by Grafana', | ||
| }); |
There was a problem hiding this comment.
I think this is perfectly fine to iterate with. I would still recommend bringing to a UX feedback session before we go beyond dev.
A simple alternate would be 'Managed by Grafana' -> 'Latest'
I would almost expect something more like the signature shield where we could have the display value as Latest and then tooltip text of "The version of this plugin is managed by Grafana Labs"
There was a problem hiding this comment.
I would almost expect something more like the signature shield where we could have the display value as Latest and then tooltip text of "The version of this plugin is managed by Grafana Labs"
💯 this is perfect. It's actually an advantage for us to manage the plugin 🏆
There was a problem hiding this comment.
Would you folks prefer I roll with "Latest" as a first go in that case? I'll see if I can fiddle with some badge if you think that's worthwhile too.
I would like to get something in place first and then take to UX as you suggested @sympatheticmoose 👍 There's feature toggles in place to prevent us from turning this on automatically anyway so we'll be controlling this manually on a per instance basis to test with first.
There was a problem hiding this comment.
IMO I would do "Managed by Grafana Labs" + badge > Latest.
wbrowne
requested review from
joshhunt and
L-M-K-B
and removed request for
a team
What this PR does / why we need it:
Adds the ability to mark a plugin as managed (dictated by backend interface) so that the plugin version cannot be modified by the user (as it is managed by Grafana). Currently Grafana Enterprise is what will control this logic (see PR here).
The UI is updated as demonstrated below.
Plugins list:
Old
New
Plugin details (not installed):
Old
New
Plugin details (update available):
Old
New
Version history:
Unchanged
Special notes for your reviewer:
https://github.com/grafana/grafana-enterprise/pull/6657