core: glfsheal encounter a SIGSEGV in __strftime_internal #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
CLANG-FORMAT FAILURE: index 1c95411a2..54d9a7186 100644
--- a/xlators/cluster/afr/src/afr-self-heal-common.c
+++ b/xlators/cluster/afr/src/afr-self-heal-common.c
@@ -1299,7 +1299,7 @@ afr_mark_split_brain_source_sinks_by_policy(
"Invalid child (%d) "
"selected by policy %s.",
fav_child, policy_str);
- return -1;
+ return -1;
} else if (fav_child >= 0) {
time = replies[fav_child].poststat.ia_mtime;
tm_ptr = localtime(&time); |
|
@GeorgeLjz what is the value of fav_child in crash? Can you please share "thread apply all bt full" data from the coredump here? |
|
I remember that the value of fav_child is something bigger than 80000000, and priv->child_count is 0 when I begin debug this issue, so I suppose I find the root cause for this crash, but after I re-open the coredump file, it seems the value of fav_child became normal with 0, and priv->child_count is 2, so I need re-investigate this issue, sorry for it. |
|
from the latest investigation, the negative value of replies[fav_child].poststat.ia_ctime=-8580258564328249088 |
glfsheal encounter a SIGSEGV in __strftime_interna called from afr_mark_split_brain_source_sinks_by_policy Root cause: ctime is negative Solution: change ctime to 0 when ctime is negative before strftime Fixes: gluster#4239 Change-Id: If6a356db60298da39a48c7979abdfbac03521aa7
mohit84
reviewed
Oct 16, 2023
| } else if (fav_child >= 0) { | ||
| time = replies[fav_child].poststat.ia_mtime; | ||
| if (time < 0) { |
There was a problem hiding this comment.
I think instead of putting a check on time value we should try to figure out why ia_mtime < 0, The glfsheal you are using is old(release-7) and the latest code is completely changed so i am not sure it is a right way to fix the issue.
@pranithk @karthik-us Can you please share your view on the same.
There was a problem hiding this comment.
figure out why ia_mtime or ia_ctime <0 maybe not so easy, but when one of the values is negative, it will make "Segmentation fault" with strftime call, and in the latest glusterfs code, it also has not the protection for it, so I suggest the protection maybe a work-around for this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glfsheal encounter a SIGSEGV in __strftime_interna called from afr_mark_split_brain_source_sinks_by_policy
Root cause: mis-compare between the int and unisgned int
Solution: convert the compare between 2 ints
Fixes: #4239
Change-Id: If6a356db60298da39a48c7979abdfbac03521aa7