add editors breakdown #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@giotab , thanks for your contribution! I added a few comments 👍🏼 |
Hi @martedesco , not sure I can see the comments 🤔 unless you mean in the PR's description? |
martedesco
reviewed
May 15, 2024
| @@ -0,0 +1,243 @@ | |||
| <template> | |||
There was a problem hiding this comment.
Would it make sense to name it BreakdownComponent.vue? As I would assume it is a singular breakdown per component e.g. languages or editors
My bad, I didn't submit them!
I will add a few things before releasing it, so no need to worry about that 🙏🏼 |
martedesco
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to see Editors usage as well, I changed the existing LanguagesBreakdown component to be more generic so that both Languages and Editors require less effort to maintain.
Here are the most significant changes:
New Features:
src/components/BreakdownsComponent.vue: Introduced a new component that provides a generic breakdown view. This component can display breakdowns by different keys such as language or editor. It includes a pie chart to visualize the top 5 items by accepted prompts and acceptance rate, and a data table for a detailed breakdown.Enhancements:
src/components/MainComponent.vue: Replaced theLanguagesBreakdowncomponent with the newBreakdownsComponent. Added 'editors' to the list of tab items to provide a breakdown by editors. [1] [2] [3]src/components/MetricsViewer.vue: Removed the processing of language breakdowns as it is now handled by theBreakdownsComponent. [1] [2]Refactoring:
src/model/Breakdown.ts: Renamed fromLanguage.tsand updated the class name toBreakdownto make it more generic.src/model/Metrics.ts: Renamed theBreakdownclass toBreakdownDataand updated thebreakdownmember of theMetricsclass to useBreakdownData. [1] [2] [3]Removals:
src/components/LanguagesBreakdown.vue: Removed this component as its functionality is now covered by theBreakdownsComponent.src/components/MetricsViewer.vue: Removed the import of theLanguagemodel as it is no longer used.