Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Ensure express spans have better data #12107

Merged
merged 2 commits into from
May 21, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented May 17, 2024

This ensures we have correct op, name & origin for all express middleware spans.

I also updated the E2E test to actually check this as well.

@mydea mydea self-assigned this May 17, 2024
Copy link
Contributor

github-actions bot commented May 17, 2024

size-limit report 📦

Path Size
@sentry/browser 21.72 KB (0%)
@sentry/browser (incl. Tracing) 32.88 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.61 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.27 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.27 KB (0%)
@sentry/browser (incl. Feedback) 37.68 KB (0%)
@sentry/browser (incl. sendFeedback) 26.29 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.66 KB (0%)
@sentry/react 24.41 KB (0%)
@sentry/react (incl. Tracing) 35.87 KB (0%)
@sentry/vue 25.66 KB (0%)
@sentry/vue (incl. Tracing) 34.69 KB (0%)
@sentry/svelte 21.86 KB (0%)
CDN Bundle 24.26 KB (0%)
CDN Bundle (incl. Tracing) 34.31 KB (0%)
CDN Bundle (incl. Tracing, Replay) 68 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.97 KB (0%)
CDN Bundle - uncompressed 71.33 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 101.74 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 211.36 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.66 KB (0%)
@sentry/nextjs (client) 35.09 KB (0%)
@sentry/sveltekit (client) 33.46 KB (0%)
@sentry/node 141.5 KB (+0.04% 🔺)
@sentry/aws-serverless 128.08 KB (0%)

@mydea mydea merged commit de60306 into develop May 21, 2024
100 checks passed
@mydea mydea deleted the fn/express-middleware-spans branch May 21, 2024 07:49
@dzienisz
Copy link

I feel you rushed 8.x too much. I will wait until a few patches come out.

@mydea
Copy link
Member Author

mydea commented May 23, 2024

I feel you rushed 8.x too much. I will wait until a few patches come out.

That's totally fair! v7 is still around and is still receiving bug fixes, so no need to update to v8 right away, if you don't want to. v8 is there waiting for you when you're ready to upgrade ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants