feat(feedback): toggle option for relay to produce to ingest-feedback #3061
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3061 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 3 3
Lines 203 203
=======================================
Hits 201 201
Misses 2 2 ☔ View full report in Codecov by Sentry. |
| @@ -134,6 +134,9 @@ def get_internal_network(): | |||
|
|
|||
| KAFKA_CLUSTERS["default"] = DEFAULT_KAFKA_OPTIONS | |||
|
|
|||
| # Temporary flag to test a new ingest consumer for user feedback. | |||
| SENTRY_OPTIONS["feedback.ingest-topic.rollout-rate"] = 1.0 | |||
There was a problem hiding this comment.
Will the default value of this option be changed in sentry? How will we know it is time to remove this temporary flag?
There was a problem hiding this comment.
The default value is 0.0 and will not be changed
There was a problem hiding this comment.
As soon as this ingest topic is tested and confirmed to work in self-hosted, I will remove references to the flag in all repos. The other deployments have all been tested already.
There was a problem hiding this comment.
Got it, so essentially the option will not be needed in the future after the references to the flag is removed
There was a problem hiding this comment.
Yup! I'll be deleting it
aliu3ntry
force-pushed
the
aliu/produce-to-feedback-topic
branch
from
e4a2e72
to
d90fd5c
Compare
…edback" This reverts commit b1b2fc0.
…o aliu/produce-to-feedback-topic
|
circling back later, see comment on #3060 |
Follow-up to (merge after) #3060