New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(curriculum): refactor decimal to binary converter to check for positive numbers only #54719
Closed
+224
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eInt(numberInput.value < 0)) { alert("Please provide a decimal number greater than or equal to 0");
…sitive numbers only
github-actions
bot
added
the
scope: curriculum
Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
label
May 9, 2024
...res-22/learn-recursion-by-building-a-decimal-to-binary-converter/63db7f4677d06d7500a13321.md
Outdated
Show resolved
Hide resolved
jdwilkin4
added
the
new javascript course
These are for issues dealing with the new JS curriculum
label
May 10, 2024
JoyShaheb
reviewed
May 13, 2024
...res-22/learn-recursion-by-building-a-decimal-to-binary-converter/63db7f4677d06d7500a13321.md
Show resolved
Hide resolved
JoyShaheb
requested changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good so far! dropped some reviews and feedbacks
...res-22/learn-recursion-by-building-a-decimal-to-binary-converter/64007367d54d2a7efbf44fcf.md
Outdated
Show resolved
Hide resolved
...res-22/learn-recursion-by-building-a-decimal-to-binary-converter/64007367d54d2a7efbf44fcf.md
Show resolved
Hide resolved
jdwilkin4
added
the
status: waiting update
To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
label
May 13, 2024
JoyShaheb
requested changes
May 16, 2024
...res-22/learn-recursion-by-building-a-decimal-to-binary-converter/645cc5925f158b5b33e2698f.md
Show resolved
Hide resolved
…a-structures-22/learn-recursion-by-building-a-decimal-to-binary-converter/64007367d54d2a7efbf44fcf.md Co-authored-by: Joy Shaheb <khondokoralam@gmail.com>
This PR was just merged in which addresses the same issue As result, we are going to close your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
new javascript course
These are for issues dealing with the new JS curriculum
scope: curriculum
Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
status: waiting update
To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
main
branch of freeCodeCamp.Closes #54651
Step 1 text updated to show project will only covert positive numbers.
#54651 (comment) @jdwilkin4
#54651 (comment) @scissorsneedfoodtoo
Updated instructions for step 12
Hint message for step 12 second condition
Hint message for step 12 third condition
Step 12 success message
Updated instructions for step 13
Hint message for step 13 - alert without text
Step 13 success message
Step 78 instructions
Hint message for step 78 - second condition
Hint message for step 78 - third condition