Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(curriculum): refactor decimal to binary converter to check for positive numbers only #54719

Closed
wants to merge 9 commits into from

Conversation

Supravisor
Copy link
Contributor

@Supravisor Supravisor commented May 9, 2024

Checklist:

Closes #54651

Step 1 text updated to show project will only covert positive numbers.
#54651 (comment) @jdwilkin4

But IMO, I think we should just add a note in the beginning for step 1 that this project will build out a binary converter for positive numbers.

#54651 (comment) @scissorsneedfoodtoo

Like Jessica mentioned, we could adjust the text in step 1 to emphasize that this project will only convert positive numbers into binary.

image

Updated instructions for step 12
image

Hint message for step 12 second condition
image

Hint message for step 12 third condition
image

Step 12 success message
image

Updated instructions for step 13
image

Hint message for step 13 - alert without text
image

Step 13 success message
image

Step 78 instructions
image

Hint message for step 78 - second condition
image

Hint message for step 78 - third condition
image

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label May 9, 2024
@Supravisor Supravisor marked this pull request as ready for review May 9, 2024 07:46
@jdwilkin4 jdwilkin4 added the new javascript course These are for issues dealing with the new JS curriculum label May 10, 2024
Copy link
Contributor

@JoyShaheb JoyShaheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good so far! dropped some reviews and feedbacks

@jdwilkin4 jdwilkin4 added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label May 13, 2024
…a-structures-22/learn-recursion-by-building-a-decimal-to-binary-converter/64007367d54d2a7efbf44fcf.md

Co-authored-by: Joy Shaheb <khondokoralam@gmail.com>
@jdwilkin4
Copy link
Contributor

This PR was just merged in which addresses the same issue
#54708

As result, we are going to close your PR

@jdwilkin4 jdwilkin4 closed this May 22, 2024
@Supravisor Supravisor deleted the dec2binPositive branch May 22, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor decimal to binary converter to check for positive numbers only
4 participants