Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(curriculum): add English curriculum block 5.3 describe tech trends or updates #54673

Merged
merged 5 commits into from
May 16, 2024
Merged

feat(curriculum): add English curriculum block 5.3 describe tech trends or updates #54673

merged 5 commits into from
May 16, 2024

Conversation

miyaliu666
Copy link
Member

Checklist:

@miyaliu666 miyaliu666 requested a review from a team as a code owner May 6, 2024 12:24
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels May 6, 2024
@miyaliu666 miyaliu666 added the new english course English Curriculum label May 6, 2024
moT01
moT01 requested changes May 7, 2024
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @miyaliu666 🎉

Couple minor adjustments.

curriculum/challenges/_meta/learn-how-to-discuss-tech-trends-and-updates/meta.json Outdated Show resolved Hide resolved
curriculum/challenges/_meta/learn-how-to-discuss-tech-trends-and-updates/meta.json Outdated Show resolved Hide resolved
...lish-for-developers/learn-how-to-discuss-tech-trends-and-updates/6635c3e30e02d224d4450eac.md Outdated Show resolved Hide resolved
@moT01 moT01 added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label May 7, 2024
@miyaliu666 @moT01
Apply suggestions from code review
901cf16 
Co-authored-by: Tom <20648924+moT01@users.noreply.github.com>
@moT01
Copy link
Member

moT01 commented May 16, 2024

I'm gonna merge this. If there's still any concerns, feel free to bring them up.

@moT01 moT01 merged commit 8ac27f9 into freeCodeCamp:main May 16, 2024
22 checks passed
@miyaliu666 miyaliu666 deleted the feat-5.3 branch May 17, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a2937 a2937 a2937 left review comments

@moT01 moT01 moT01 approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

@nieldakarla nieldakarla Awaiting requested review from nieldakarla

Assignees
No one assigned
Labels
new english course English Curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@miyaliu666 @moT01 @a2937 @naomi-lgbt