refactor(api): more, smaller tests #54671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a little less direct, but ensure that get-session-user correctly reflects the change in the db.
github-actions
bot
added
the
platform: api
ojeytonwilliams
changed the title
moT01
added
the
status: waiting review
naomi-lgbt
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.I was a little unsure about what the
/exam-challenge-completedendpoint was expected to do, so I split the tests up. The is a little more boilerplate as a result, but each test is now more focused. It should be clear which behaviour they're asserting.I also moved one of the tests from checking the db directly, to using
get-session-user. The reason for this is simply it's more useful to know how an update modifies the api's behaviour (i.e. how subsequent requests will play out) than how it modifies the internals. I'll extend this to the other tests in a followup PR, since that requires updatingget-session-user's behaviour and I wanted to limit this to being a refactor.