fix(curriculum): Rewrite of Create Reusable CSS with Mixins module #54657
+128
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Mixins module" This reverts commit d1134aa.
github-actions
bot
added
the
scope: curriculum
moT01
added
the
status: waiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.Closes #50155
As per @lasjorg's suggestions, I removed any references to vendor prefixing as they are unnecessary and outdated.
In this rewrite, I kept the general structure of the challenge text but modified to suit the new example code. However, I didn't use the @mixin prose example given by @lasjorg as I think it'll be better to build on the previous challenges. So I did my own simple example about individual styles on headings, which is covered in previous challenges.
As for the task itself, I used @lasjorg's suggestion with some add-ons.
Tagging @naomi-lgbt for visibility.
Also, I messed up my git commits so there's multiple commits in my branch. I'm not sure if that's acceptable, apologies. Please let me know if I have to fix it.
I've opened a PR before this one, but because I messed up my commit history, the previous PR got closed so I'm opening this new one, very sorry for the inconveniences.
Thank you!