Docker #1170

squatica · 2020-02-07T06:02:14Z

Hi,
building on top of the PR #1162 updated the branches with current master and joined mine and @akash07k 's changes together into this PR. I suggest to squash all the commits together (maybe except deasync and '--dev'), because it's pretty confusing as it is. I left them separate for now just in case you prefer to look at all the single commits.

squatica · 2020-02-14T12:02:25Z

@jtojnar What do you think? Can it be merged? Or anything else necessary?

jtojnar

Thank you for the PR and sorry I did not get to this yet.

From a glance it looks mostly okay except few things – there are too many extra files in the root of the repository. I am already trying to remove things (#913) and plan to continue in the future. Are you absolutely sure none of these files can be moved to utils subdirectory?

Maybe at least the .dev.yml could be moved since it already needs to be referenced explicitly.

Also the dockerfiles themselves look incredibly complex. I wonder if it would be okay to just use PHP’s built in server instead of Apache.

.dockerignore

jtojnar · 2020-02-14T12:13:22Z

.env.dist

@@ -0,0 +1,2 @@
+UID=1000


Is there not a better way to mount the dev directory without needing uid/gid? Not only this adds to the clutter but it also feels a bit wonky.

Unfortunately, this is a years-long issue with docker and volumes - moby/moby#2259. And in this case we need the executor of npm run dev to match the owner of the mounted directory, which can be anything. This solutions is one of the least complicated and working.

README.md

jtojnar · 2020-02-14T12:23:16Z

assets/package-lock.json

@@ -1888,10 +1888,13 @@
      "dev": true


This should not be part of this PR. Will cherry-pick to master.

jtojnar · 2020-02-14T12:23:34Z

package.json

@@ -26,7 +26,7 @@
    "fix:server": "composer run-script fix",
    "install-dependencies": "npm run install-dependencies:client && npm run install-dependencies:server",
    "install-dependencies:client": "npm install --production=false --prefix assets/",
-    "install-dependencies:server": "composer install --dev",


utils/docker/entrypoint.sh

squatica · 2020-02-16T13:53:03Z

OK, I tested how it works with docker-compose files in utils/docker and it seems to be fine. It's not standard but works.

About Apache - I'd rather keep it, because there are a bunch of .htaccess files which will all stop working under php builtin server. Also php builtin server should not be used for production. What do you find complex about the Dockerfiles? They seem quite small to me, I've seen much worse :-D The production one is split into three parts using multi-staged build because we don't need npm nor composer for the production runtime environment. And the dev dockerfile basically only installs node and composer according to their official installation instructions. One minor simplification will become possible once the config.ini location is configurable or moved into data directory as suggested by #913 .

akash07k · 2020-02-16T15:09:10Z

Thanks a lot @squatica for this.
It's working great so far.
Actually I was out of station so couldn't pay attention to it till now.
Thanks a tons for your efforts into this!

squatica · 2020-02-17T06:23:33Z

Hey @akash07k nice to hear from you again, I was worried what happened to you 😃

@jtojnar I created a docker hub account for selfoss, I'm going to configure automatic builds of the production image. Let me know how I can transfer the ownership to you.

akash07k · 2020-02-17T12:08:18Z

@squatica
Yes buddy. actually I went on vacations for sometime and my laptop wasn't with me.
I'm back now.
how are you?
and I'm very greatful for you for your efforts.
I pinged you on gitter a month back but probably you were busy then.

Hey @akash07k nice to hear from you again, I was worried what happened to you 😃

@jtojnar I created a docker hub account for selfoss, I'm going to configure automatic builds of the production image. Let me know how I can transfer the ownership to you.

akash07k · 2020-03-10T17:23:24Z

Isn't it yet ready for merge?

jtojnar · 2020-03-28T19:06:09Z

The main blocker is that we do not have anyone knowledgable in Docker to properly review this.

akash07k · 2020-03-29T04:31:12Z

:(

…

On 3/29/20, Jan Tojnar ***@***.***> wrote: The main blocker is that we do not have anyone knowledgable in Docker to properly review this. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #1170 (comment)

kolaente · 2020-04-07T20:28:31Z

Looks quite good, I have a few ideas:

I would suggest creating the dev image on top of the production image - that way you get the benefit of having the same docker image for dev and prod (well, almost at least).
Another approach would be to have a seperate "workspace" container which contains all the tools needed for development (composer etc) and has the same mounts as the prod image. Both would run side by side, but the prod image based container would only host the files - and be the same as any "real" prod deployment. This one would then also do things like running the frontend watcher on startup.

akash07k · 2020-05-01T16:23:06Z

Looks quite good, I have a few ideas:

I would suggest creating the dev image on top of the production image - that way you get the benefit of having the same docker image for dev and prod (well, almost at least).

Another approach would be to have a seperate "workspace" container which contains all the tools needed for development (composer etc) and has the same mounts as the prod image. Both would run side by side, but the prod image based container would only host the files - and be the same as any "real" prod deployment. This one would then also do things like running the frontend watcher on startup.
Good ideas,
I'm not that expert in Docker otherwise I would have tried working on these.
@squatica opinions bro?

akash07k · 2020-05-01T16:23:40Z

It seems that now there are some package conflicts in package.lock.json due to the dependency updates. :-)

… named ast"

@kolaente

Hi guys, I'm still alive. I rebased this PR on top of the current master & solved the conflicts. I'm looking into @kolaente's remarks, it should be possible so I'll do it. Unfortunately I lost access to my email and github started asking for email verification, so I cannot login to github web, but I can still commit. Hopefully the support will let me recover the account. If not then I'll have to continue under different username.

desaintmartin · 2021-10-10T19:41:24Z

Hello,
An official container image would be really nice (and I may even build a Helm Chart for Kubernetes on top of this). Could we help in anything in order to have this merged and the image automatically built/published somewhere?

jtojnar · 2021-10-11T16:32:30Z

Sorry, I do not really use docker so it has been difficult for me to allocate time to it. I will try to do something with #1271 this week.

armandabric · 2021-10-13T12:02:15Z

If you need some help with it, I'm running https://github.com/armandabric/docker-selfoss since few year now. I hope it could help

jtojnar reviewed Feb 14, 2020

View reviewed changes

Akash Kakkar and others added 9 commits May 16, 2020 10:39

squashed commits from @akash07k

a5d6d75

had to upgrade deasync to 0.1.16 otherwise npm failed with "No module…

f44a6ff

… named ast"

"--dev" is obsolete

66a21a0

dockerizing selfoss, fixes fossar#1161

987afc0

simplified sed replacement

ae802d2

moved docker instructions into separate Readme

8b334bb

removing dockerignore

11031d9

moved docker-compose files into utils/docker

3d8fd32

squatica force-pushed the docker branch from 45aac1c to f7786f9 Compare May 16, 2020 09:22

jtojnar mentioned this pull request Aug 3, 2020

Question: Reddit content only in markdown? #1208

Closed

jtojnar added this to the 2.19 milestone May 6, 2021

jtojnar force-pushed the master branch from b0e2867 to f52346b Compare May 12, 2022 16:47

jtojnar mentioned this pull request Jul 22, 2022

Docker Container #1350

Open

desaintmartin mentioned this pull request May 29, 2023

feat(docker): add basic docker support #1433

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docker #1170

Docker #1170

squatica commented Feb 7, 2020

squatica commented Feb 14, 2020

jtojnar left a comment

jtojnar Feb 14, 2020

squatica Feb 14, 2020

jtojnar Feb 14, 2020

jtojnar Feb 14, 2020

squatica commented Feb 16, 2020

akash07k commented Feb 16, 2020

squatica commented Feb 17, 2020

akash07k commented Feb 17, 2020

akash07k commented Mar 10, 2020

jtojnar commented Mar 28, 2020

akash07k commented Mar 29, 2020 via email

kolaente commented Apr 7, 2020 •

edited

akash07k commented May 1, 2020

akash07k commented May 1, 2020

desaintmartin commented Oct 10, 2021

jtojnar commented Oct 11, 2021

armandabric commented Oct 13, 2021

Docker #1170

Are you sure you want to change the base?

Docker #1170

Conversation

squatica commented Feb 7, 2020

squatica commented Feb 14, 2020

jtojnar left a comment

Choose a reason for hiding this comment

jtojnar Feb 14, 2020

Choose a reason for hiding this comment

squatica Feb 14, 2020

Choose a reason for hiding this comment

jtojnar Feb 14, 2020

Choose a reason for hiding this comment

jtojnar Feb 14, 2020

Choose a reason for hiding this comment

squatica commented Feb 16, 2020

akash07k commented Feb 16, 2020

squatica commented Feb 17, 2020

akash07k commented Feb 17, 2020

akash07k commented Mar 10, 2020

jtojnar commented Mar 28, 2020

akash07k commented Mar 29, 2020 via email

kolaente commented Apr 7, 2020 • edited

akash07k commented May 1, 2020

akash07k commented May 1, 2020

desaintmartin commented Oct 10, 2021

jtojnar commented Oct 11, 2021

armandabric commented Oct 13, 2021

kolaente commented Apr 7, 2020 •

edited