Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Arabic Localization Files (super minor) #20852

Open
wants to merge 48 commits into
base: main
Choose a base branch
from

Conversation

jadenfreude
Copy link

@jadenfreude jadenfreude commented Apr 9, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Added Arabic localizations files. Translations are 90% there, it needs more Arabic-speaking contributors to get to 100%.

Note: this is meant to help with the RTL support issue by providing an RTL language to test with.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Semantic HTML implemented?
  • Keyboard operability supported?
  • Checked with axe DevTools and addressed Critical and Serious issues?
  • Color contrast tested?

For more info, check out the
Forem Accessibility Docs.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: they're localization files, there's little to test.
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

too much for too little

@jadenfreude jadenfreude requested review from a team as code owners April 9, 2024 11:53
@jadenfreude jadenfreude requested review from maestromac and lightalloy and removed request for a team April 9, 2024 11:53
Copy link
Contributor

github-actions bot commented Apr 9, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Contributor

github-actions bot commented Apr 9, 2024

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

@jadenfreude
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@jadenfreude
Copy link
Author

recheck

@jadenfreude jadenfreude changed the title Adding Arabic Localization Files Adding Arabic Localization Files (super minor) Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant