Test InputDecoration API examples #148560
Open
+360
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
github-actions
bot
added
the
f: material design
|
@NobodyForNothing thanks for contributing! It looks like there are some failing checks, can you take a look? |
NobodyForNothing
force-pushed
the
130459-input_decoration
branch
from
985a8b8
to
e16bf85
Compare
TahaTesser
requested changes
May 29, 2024
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| testWidgets('Shows all decorations', (WidgetTester tester) async { |
There was a problem hiding this comment.
Suggested change
| testWidgets('Shows all decorations', (WidgetTester tester) async { | |
| testWidgets('TextField is decorated', (WidgetTester tester) async { |
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| testWidgets('Shows all decorations', (WidgetTester tester) async { |
There was a problem hiding this comment.
Suggested change
| testWidgets('Shows all decorations', (WidgetTester tester) async { | |
| testWidgets('TextField is decorated', (WidgetTester tester) async { |
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| testWidgets('Shows all decorations', (WidgetTester tester) async { |
There was a problem hiding this comment.
Suggested change
| testWidgets('Shows all decorations', (WidgetTester tester) async { | |
| testWidgets('TextFormField is decorated', (WidgetTester tester) async { |
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| testWidgets('Shows the whole app', (WidgetTester tester) async { |
There was a problem hiding this comment.
Suggested change
| testWidgets('Shows the whole app', (WidgetTester tester) async { | |
| testWidgets('Shows the whole app', (WidgetTester tester) async { |
This title can be improved,
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| testWidgets('Shows all decorations', (WidgetTester tester) async { |
There was a problem hiding this comment.
Suggested change
| testWidgets('Shows all decorations', (WidgetTester tester) async { | |
| testWidgets('Shows all decorations', (WidgetTester tester) async { |
Same here
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| testWidgets('Shows all decorations', (WidgetTester tester) async { |
There was a problem hiding this comment.
Suggested change
| testWidgets('Shows all decorations', (WidgetTester tester) async { | |
| testWidgets('Shows all decorations', (WidgetTester tester) async { |
Same here
| greaterThan(tester.getSize(smallerIcon).longestSide)); | ||
| }); | ||
|
|
||
| testWidgets('Is suffix icon', (WidgetTester tester) async { |
There was a problem hiding this comment.
Suggested change
| testWidgets('Is suffix icon', (WidgetTester tester) async { | |
| testWidgets('Is suffix icon', (WidgetTester tester) async { |
Not sure what this means.
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| testWidgets('Shows all decorations', (WidgetTester tester) async { |
There was a problem hiding this comment.
Suggested change
| testWidgets('Shows all decorations', (WidgetTester tester) async { | |
| testWidgets('Shows all decorations', (WidgetTester tester) async { |
Same here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for
InputDecorationAPI example as part of #130459. Updates examples that use the deprecated MaterialState to use WidgetState. Tests files:input_decoration.0.dart,input_decoration.1.dart,input_decoration.2.dart,input_decoration.3.dart,input_decoration.widget_state.0.dart,input_decoration.widget_state.1.dart,input_decoration.prefix_icon_constraints.0.dart,input_decoration.suffix_icon_constraints.0.dart, andinput_decoration.label.0.dartPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.