Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: JS Notification extender #3974

Merged
merged 3 commits into from May 14, 2024
Merged

feat: JS Notification extender #3974

merged 3 commits into from May 14, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Mar 24, 2024

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 marked this pull request as ready for review May 14, 2024 20:09
@SychO9 SychO9 requested a review from a team as a code owner May 14, 2024 20:09
@SychO9 SychO9 merged commit 29ede5a into 2.x May 14, 2024
10 of 29 checks passed
@SychO9 SychO9 deleted the sm/js-notification-extender branch May 14, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant