Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tags): Edit tags icon fontawesome url to v5 #3965

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

dian-kaagman
Copy link

Fixes #0000 (no issue)

Changes proposed in this pull request:
The Fontawesome url referred to the newest icons overview, since the tags extension only supports v5 icons it's confusing for admin users why some icons don't work. The url for supported icons is: https://fontawesome.com/v5/icons?m=free.

Scherm­afbeelding 2024-02-21 om 13 48 20

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@dian-kaagman dian-kaagman requested a review from a team as a code owner February 21, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants