Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] fix: reset admin page save button in catch handler #3963

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

YUCLing
Copy link

@YUCLing YUCLing commented Feb 3, 2024

Fixes #3962

Changes proposed in this pull request:
Add a catch handler to saveSettings() to reset admin page's save button state.

Reviewers should focus on:
Should a newly added function that only sets loading to false be created.

Screenshot
No much changes will be shown to users.

QA
Create a Saving event listener and throw an exception to create a saving error.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@YUCLing YUCLing requested a review from a team as a code owner February 3, 2024 05:46
@YUCLing
Copy link
Author

YUCLing commented Mar 17, 2024

Should I also create a PR to fix this in 2.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants