chore(mentions): add integration test for reply approval notification #3748
Conversation
| ] | ||
| ]) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Should there be another assert after here?
There was a problem hiding this comment.
an $this->assertEquals(1, $mainUser->getUnreadNotificationCount()); is what will confirm this works.
| ['id' => 33, 'title' => __CLASS__, 'created_at' => Carbon::now(), 'last_posted_at' => Carbon::now(), 'user_id' => 1, 'first_post_id' => 33, 'comment_count' => 6, 'last_post_number' => 6, 'last_post_id' => 38], | ||
| ], | ||
| 'posts' => [ | ||
| ['id' => 1, 'discussion_id' => 1, 'created_at' => Carbon::createFromDate(1975, 5, 21)->toDateTimeString(), 'user_id' => 1, 'type' => 'comment', 'content' => '<t><p>foo bar</p></t>', 'number' => 1], |
There was a problem hiding this comment.
Do we need this much loading data?
There was a problem hiding this comment.
we can delete the 33 discussion and posts from 33+
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
SychO9
dismissed
their stale review
Not sure why I assumed this was completed, looking again it isn't. @OrdinaryJellyfish could you look into this please
| 'json' => [ | ||
| 'data' => [ | ||
| 'attributes' => [ | ||
| 'content' => 'reply with predetermined content for automated testing - too-obscure', |
There was a problem hiding this comment.
To test the reply notification works let's add a post mention (post mention = replying to a post)
we should try to mention a post created by mainUser (userId = 2) so let's do @"mainUser"#p2
and change the user_id of post id 2 to 2
| $json = json_decode($response->getBody()->getContents(), true); | ||
|
|
||
| $this->send( | ||
| $this->request('PATCH', '/api/posts'.$json['data']['id'], [ |
There was a problem hiding this comment.
| $this->request('PATCH', '/api/posts'.$json['data']['id'], [ | |
| $this->request('PATCH', '/api/posts/'.$json['data']['id'], [ |
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
Necessity
Confirmed
composer test).Required changes: