feat(vertex): Add auth support in the vertexai #12797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
approved these changes
May 17, 2024
russellwheatley
requested changes
May 20, 2024
There was a problem hiding this comment.
analyse CI needs fixing: https://github.com/firebase/flutterfire/actions/runs/9132787893/job/25114851878?pr=12797#step:5:338
Other than that, LGTM.
packages/firebase_vertexai/firebase_vertexai/example/lib/main.dart
Outdated
Show resolved
Hide resolved
russellwheatley
approved these changes
May 21, 2024
|
@cynthiajoan - is this going in after this PR? #12794 |
I'm thinking to have this in before that PR, I will sync with @natebosch to double check |
Sounds good - I'll watch for this one to land and then resolve any merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the support for auth token in vertex request
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?