-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix): updating sdk invocation versions #3393
base: main
Are you sure you want to change the base?
Conversation
@bsinghvi you'll need to fix ete tests here |
is there a way to make this dynamic? I'm inspired by what Armando did here: Line 79 in 8633c28
|
@dannysheridan there would still have to be some level of manual intervention to determine which version we should mark as safe to be the default invocation version. right now, Armando's just grabs the latest, which could potentially not be release safe |
0636916
to
c0dc86e
Compare
That's right -- in fact the latest TS release has some issues so have to wait to merge this |
@dsinghvi this PR doesn't update it to the latest for the TypeScript SDK - are there concerns with 12.9? |
@dsinghvi can you land this PR? |
Used the generator versions here - https://github.com/fern-api/fern?tab=readme-ov-file + the changelog to decide on the default version.